-
-
Notifications
You must be signed in to change notification settings - Fork 299
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
…dre) This PR was merged into the 2.x branch. Discussion ---------- [Map] Rename `render_map` Twig function `ux_map` | Q | A | ------------- | --- | Bug fix? | no | New feature? | no | Issues | Fix #... | License | MIT ### Context As we recently saw with the `cva` function and forgot to do here: we should prefix every new component / package / Twig function or filter with `ux` to avoid conflict with existing codebases... and with future symfony or twig new methods. ### This PR This PR renames `render_map` (inspired by charts hjs "render_chart") into `ux_map` (in line with what we did for UX Icons) ```diff <div> - {{ render_map(map) }} + {{ ux_map(map) }} </div> ``` ### Next We can keep the render_map for _some_ time, but it's marked as deprecated right now, and i think this is the good moment to update documentation, to limit future BC break / changes for users (even if we are in experimental) ### Website Once this once is merged, the website page will need to be updated Commits ------- b539c1a Rename `render_map` Twig function `ux_map`
- Loading branch information
Showing
6 changed files
with
19 additions
and
8 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters