[Map] Render map from Twig with ux_map() and <twig:ux:map />

[smnandre]

Q	A
Bug fix?	no
New feature?	yes
Issues	Fix #...
License	MIT

• add an MapFactory (internal)
• allow ux_map Twig function to render map from named arguments
• add basic TwigComponent <twig:ux:map ... />

Create Map from Twig

{{ ux_map(
    center: [51.5074, 0.1278],
    zoom: 3,
    markers:  [
        { position: [51.5074, 0.1278], title: 'London' },
        { position: [48.8566, 2.3522], title: 'Paris' },
        {
            position: [40.7128, -74.0060],
            title: 'New York',
            infoWindow: { content: 'Welcom to <b>New York</b>' }
        },
    ],
    attributes: {
        class: 'foo',
        style: 'height: 800px; width: 100%; border: 4px solid red; margin-block: 10vh;',
    }
) }}

[Kocal]

Thanks for working on this!
It looks nice to me, but I have many comments on the validation part where I'm not 100% sure of its legitimacy (we use PHP types, and I'm afraid all those code/function calls can downgrade performances)

[Kocal]

See #2152 as a lighter (but not complete yet) alternative

[smnandre]

Yeah i'll use the fromArray static from your PR and we'll see... but i hope this will simplify a lot this one.

Thanks !

[smnandre]

Integrated the ideas fom #2152

[Kocal]

That looks much better to me, thanks :)

Still minor comments tho

[Kocal]

Suggested change

	if (isset($point['lat'], $point['lng'])) {
	if ($point['lat'] ?? null && $point['lng'] ?? null) {

so we can allow users to pass 0 as lat/lng

[smnandre]

$pos = ['lat' => 0, 'lng' => 0];

echo isset($pos['lat'], $pos['lng']);

# 1

The only case would be $pos = [0, 0] and i don't mind that much 😅

[Kocal]

(sorry I approved by mistake)

[Kocal]

Do we need to mark test files internal?

[Kocal]

Thanks @smnandre for working on this feature, this is much appreciated.

[smnandre]

Thanks @Kocal for the help / suggestions / feedback ❤️

I'll add doc asap, but I now can work on demos with twig content, and i think it's gonna be more effective to showcase the component!