Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow custom EntrypointLookupCollection when instantiating the TagRenderer #104

Merged
merged 1 commit into from
Feb 10, 2021

Conversation

richardhj
Copy link
Contributor

Hi 👋

There is an interface "EntrypointLookupCollectionInterface" but I wonder why the TagRender is not making use of it?

I want to override the TagRenderer to work with another EntrypointLookupCollection, so I defined my own service:

    app.tag_renderer:
        class: Symfony\WebpackEncoreBundle\Asset\TagRenderer
        arguments:
            - '@app.entrypoint_lookup_collection'
            - '@assets.packages'
            - []
            - []
            - []
            - '@event_dispatcher'
        tags:
            - { name: 'kernel.reset', method: 'reset'}

@richardhj
Copy link
Contributor Author

richardhj commented Jan 25, 2021

@weaverryan
Copy link
Member

Looks like this was a detail we missed - thanks Richard!

@weaverryan weaverryan merged commit f9a9b5b into symfony:main Feb 10, 2021
@richardhj richardhj deleted the patch-1 branch February 10, 2021 20:07
richardhj added a commit to richardhj/contao that referenced this pull request Feb 11, 2021
richardhj added a commit to richardhj/contao that referenced this pull request Feb 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants