Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Stimulus: move deprecations from DTOs to filters/functions #186

Merged
merged 1 commit into from
Jul 13, 2022
Merged

Stimulus: move deprecations from DTOs to filters/functions #186

merged 1 commit into from
Jul 13, 2022

Conversation

jmsche
Copy link
Contributor

@jmsche jmsche commented Jul 7, 2022

As discussed with @weaverryan on Slack, I'm moving deprecation triggers from DTOs to Twig filters/functions.

jrushlow
jrushlow approved these changes Jul 12, 2022
View reviewed changes
Copy link
Collaborator

@jrushlow jrushlow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @jmsche

@jrushlow jrushlow added Minor Minor Enhancement Status: Reviewed Has been reviewed by a maintainer Bug Bug Fix and removed Minor Minor Enhancement labels Jul 12, 2022
@weaverryan
Copy link
Member

Thanks @jmsche!

@weaverryan weaverryan merged commit 6478066 into symfony:main Jul 13, 2022
@jmsche jmsche deleted the move-deprecations-to-twig-extension branch July 24, 2023 09:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jrushlow jrushlow jrushlow approved these changes

Assignees
No one assigned
Labels
Bug Bug Fix Status: Reviewed Has been reviewed by a maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jmsche @weaverryan @jrushlow