Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Doctype now lowercase as per h5bp. #13

Merged
merged 3 commits into from
Apr 22, 2015
Merged

Doctype now lowercase as per h5bp. #13

merged 3 commits into from
Apr 22, 2015

Conversation

jurajkapsz
Copy link
Contributor

No description provided.

@nitriques
Copy link
Member

@jurajkapsz Would you mind adding a commit that creates a new version in the xml file please ?

That way, I can release it faster!

@jurajkapsz jurajkapsz changed the title Doctype now lowercase as per hb5p. Doctype now lowercase as per h5bp. Apr 22, 2015
@jurajkapsz
Copy link
Contributor Author

@nitriques about to do :)

@michael-e
Copy link
Member

Doctype now lowercase as per hb5p.

What is hb5p?

@nitriques
Copy link
Member

@jurajkapsz Thanks! Could you add max="2.6.x" on the release tag too ?

What is hp5p?

@michael-e It's h5bp https://github.com/h5bp/html5-boilerplate

@jurajkapsz
Copy link
Contributor Author

@michael-e sorry, was a typo

@michael-e
Copy link
Member

Ah, I see, thanks!

@jurajkapsz
Copy link
Contributor Author

add max="2.6.x"

@nitriques ok done

nitriques added a commit that referenced this pull request Apr 22, 2015
Doctype now lowercase as per h5bp.
@nitriques nitriques merged commit e0b537d into symphonists:integration Apr 22, 2015
@nitriques
Copy link
Member

Thanks!

@jurajkapsz jurajkapsz deleted the integration branch April 22, 2015 18:48
@nitriques
Copy link
Member

See #14

@jurajkapsz jurajkapsz restored the integration branch April 22, 2015 18:50
@michael-e
Copy link
Member

FYI: Looking at the W3C recommendation, lowercase seems to be valid. Nevertheless, I always find it written in uppercase letters (the only exception being h5bp). Personally, I'd prefer to have this in uppercase letters in my documents.

@jurajkapsz
Copy link
Contributor Author

Nevertheless, I always find it written in uppercase letters (the only exception being h5bp)

Yes, me too and always had it so. h5bp changed it in their v5 template release, I guess they chew it thoroughly in a way, h5bp/html5-boilerplate#1522

@michael-e
Copy link
Member

Thanks for the link, interesting discussion there. I will have to sleep on it.

@nitriques
Copy link
Member

@michael-e all of the html is lowercase. Always seemed weird to have a upper case doctype...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants