Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add hadamard product printing for mathml #16483

Merged
merged 3 commits into from
Apr 7, 2019

Conversation

sylee957
Copy link
Member

References to other Issues or PRs

Brief description of what is fixed or changed

I'm not sure if anything exists for mathml content printer.

Other comments

Release Notes

  • printing
    • Add support for HadamardProduct in mathml presentation printer.

@sympy-bot
Copy link

sympy-bot commented Mar 29, 2019

Hi, I am the SymPy bot (v145). I'm here to help you write a release notes entry. Please read the guide on how to write release notes.

Your release notes are in good order.

Here is what the release notes will look like:

  • printing
    • Add support for HadamardProduct in mathml presentation printer. (#16483 by @sylee957)

This will be added to https://github.com/sympy/sympy/wiki/Release-Notes-for-1.5.

Note: This comment will be updated with the latest check if you edit the pull request. You need to reload the page to see it.

Click here to see the pull request description that was parsed.

<!-- Your title above should be a short description of what
was changed. Do not include the issue number in the title. -->

#### References to other Issues or PRs
<!-- If this pull request fixes an issue, write "Fixes #NNNN" in that exact
format, e.g. "Fixes #1234". See
https://github.com/blog/1506-closing-issues-via-pull-requests . Please also
write a comment on that issue linking back to this pull request once it is
open. -->


#### Brief description of what is fixed or changed

I'm not sure if anything exists for mathml content printer.

#### Other comments


#### Release Notes

<!-- Write the release notes for this release below. See
https://github.com/sympy/sympy/wiki/Writing-Release-Notes for more information
on how to write release notes. The bot will check your release notes
automatically to see if they are formatted correctly. -->

<!-- BEGIN RELEASE NOTES -->
- printing
  - Add support for `HadamardProduct` in mathml presentation printer.
<!-- END RELEASE NOTES -->

Update

The release notes on the wiki have been updated.

@codecov
Copy link

codecov bot commented Mar 29, 2019

Codecov Report

Merging #16483 into master will increase coverage by 0.173%.
The diff coverage is 100%.

@@             Coverage Diff              @@
##            master   #16483       +/-   ##
============================================
+ Coverage   73.606%   73.78%   +0.173%     
============================================
  Files          618      619        +1     
  Lines       158593   158666       +73     
  Branches     37219    37186       -33     
============================================
+ Hits        116735   117064      +329     
+ Misses       36436    36195      -241     
+ Partials      5422     5407       -15

@oscarbenjamin
Copy link
Collaborator

This needs a test

@oscargus
Copy link
Contributor

oscargus commented Apr 4, 2019

I will review this, but can you @sylee957 please add a screen dump of what the result looks like? (A test will also be an alternative as I can easily render it myself then.)

@sylee957
Copy link
Member Author

sylee957 commented Apr 6, 2019

So far, I have added two tests from test_latex

  • mathml(HadamardProduct(X, Y*Y), printer="presentation")
    image
  • mathml(HadamardProduct(X, Y)*Y, printer="presentation")
    image

Unfortunately, my web browser does not allow mathml, so I could only render with
http://www.mathmlcentral.com/Tools/FromMathML.jsp

Copy link
Contributor

@oscargus oscargus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! I think the number of tests etc are OK. Are you planning to add more? If not, it can be merged.

@sylee957 sylee957 changed the title WIP : Add hadamard product printing for mathml Add hadamard product printing for mathml Apr 7, 2019
@smichr smichr merged commit 4dd26b0 into sympy:master Apr 7, 2019
@sylee957 sylee957 deleted the add_hadamard_product_mathml branch July 31, 2019 03:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants