-
-
Notifications
You must be signed in to change notification settings - Fork 4.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add hadamard product printing for mathml #16483
Conversation
✅ Hi, I am the SymPy bot (v145). I'm here to help you write a release notes entry. Please read the guide on how to write release notes. Your release notes are in good order. Here is what the release notes will look like: This will be added to https://github.com/sympy/sympy/wiki/Release-Notes-for-1.5. Note: This comment will be updated with the latest check if you edit the pull request. You need to reload the page to see it. Click here to see the pull request description that was parsed.
Update The release notes on the wiki have been updated. |
Codecov Report
@@ Coverage Diff @@
## master #16483 +/- ##
============================================
+ Coverage 73.606% 73.78% +0.173%
============================================
Files 618 619 +1
Lines 158593 158666 +73
Branches 37219 37186 -33
============================================
+ Hits 116735 117064 +329
+ Misses 36436 36195 -241
+ Partials 5422 5407 -15 |
This needs a test |
I will review this, but can you @sylee957 please add a screen dump of what the result looks like? (A test will also be an alternative as I can easily render it myself then.) |
So far, I have added two tests from
Unfortunately, my web browser does not allow mathml, so I could only render with |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! I think the number of tests etc are OK. Are you planning to add more? If not, it can be merged.
References to other Issues or PRs
Brief description of what is fixed or changed
I'm not sure if anything exists for mathml content printer.
Other comments
Release Notes
HadamardProduct
in mathml presentation printer.