16987: remove dups in Intersection at instantiation #16988
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
References to other Issues or PRs
Fixes #16987 without fully addressing the fact that a different wrong value is being returned from
Intersection({1}, {x})
. The value of{1}
is being returned bysimplify_intersection
. (But this is only true ifx
is also1
.)Brief description of what is fixed or changed
Intersection simplification depends on the presence of duplicates as shown in the issue. In addition, there is some indeterminancy in the processing because the arguments are not sorted.
This PR fixes both those issue.
Other comments
Release Notes