Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix flake8 warnings for sets and use PowerSet instead of None in .powerset #17775

Merged
merged 1 commit into from
Oct 23, 2019

Conversation

sylee957
Copy link
Member

References to other Issues or PRs

Brief description of what is fixed or changed

I've cleaned up some flake8 warnings for unused imports and variables.

Also, I've changed the behavior of .powerset to return PowerSet object instead of None for infinite sets like interval, which has better capability.

Other comments

Release Notes

  • sets
    • Set.powerset will return PowerSet instead of None for infinite sets.

@sympy-bot
Copy link

sympy-bot commented Oct 22, 2019

Hi, I am the SymPy bot (v149). I'm here to help you write a release notes entry. Please read the guide on how to write release notes.

Your release notes are in good order.

Here is what the release notes will look like:

  • sets
    • Set.powerset will return PowerSet instead of None for infinite sets. (#17775 by @sylee957)

This will be added to https://github.com/sympy/sympy/wiki/Release-Notes-for-1.5.

Note: This comment will be updated with the latest check if you edit the pull request. You need to reload the page to see it.

Click here to see the pull request description that was parsed.

<!-- Your title above should be a short description of what
was changed. Do not include the issue number in the title. -->

#### References to other Issues or PRs
<!-- If this pull request fixes an issue, write "Fixes #NNNN" in that exact
format, e.g. "Fixes #1234". See
https://github.com/blog/1506-closing-issues-via-pull-requests . Please also
write a comment on that issue linking back to this pull request once it is
open. -->


#### Brief description of what is fixed or changed

I've cleaned up some flake8 warnings for unused imports and variables.

Also, I've changed the behavior of `.powerset` to return `PowerSet` object instead of `None` for infinite sets like interval, which has better capability.

#### Other comments


#### Release Notes

<!-- Write the release notes for this release below. See
https://github.com/sympy/sympy/wiki/Writing-Release-Notes for more information
on how to write release notes. The bot will check your release notes
automatically to see if they are formatted correctly. -->

<!-- BEGIN RELEASE NOTES -->
- sets
  - `Set.powerset` will return `PowerSet` instead of `None` for infinite sets.
<!-- END RELEASE NOTES -->

Update

The release notes on the wiki have been updated.

@oscarbenjamin
Copy link
Collaborator

Looks good

@oscarbenjamin oscarbenjamin merged commit 7dc5b98 into sympy:master Oct 23, 2019
@sylee957 sylee957 deleted the fix_flake8_sets branch October 28, 2019 04:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants