Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

moved all the relevant solver-related test cases to test_solvers.py #18704

Closed
wants to merge 3 commits into from

Conversation

sksingh1202
Copy link
Contributor

@sksingh1202 sksingh1202 commented Feb 21, 2020

References to other Issues or PRs:
Partial fix for #18666

Brief description of what is fixed or changed

moved all the solver - related test cases from the existing files test_matrices.py and test_commonmatrix.py to a new file test_solvers.py.

Other comments

Release Notes

  • matrices
    • Added test_solvers.py file which contains all the solver-related test cases.

@sympy-bot
Copy link

sympy-bot commented Feb 21, 2020

Hi, I am the SymPy bot (v157). I'm here to help you write a release notes entry. Please read the guide on how to write release notes.

Your release notes are in good order.

Here is what the release notes will look like:

  • matrices
    • Added test_solvers.py file which contains all the solver-related test cases. (#18704 by @sksingh1202)

This will be added to https://github.com/sympy/sympy/wiki/Release-Notes-for-1.6.

Note: This comment will be updated with the latest check if you edit the pull request. You need to reload the page to see it.

Click here to see the pull request description that was parsed.

**References to other Issues or PRs:**
Partial fix for #18666 


#### Brief description of what is fixed or changed
moved all the solver - related test cases from the existing files test_matrices.py and test_commonmatrix.py to a new file test_solvers.py.

#### Other comments


#### Release Notes

<!-- Write the release notes for this release below. See
https://github.com/sympy/sympy/wiki/Writing-Release-Notes for more information
on how to write release notes. The bot will check your release notes
automatically to see if they are formatted correctly. -->

<!-- BEGIN RELEASE NOTES -->

- matrices
  -  Added test_solvers.py file which contains all the solver-related test cases.

<!-- END RELEASE NOTES -->

@sympy-bot
Copy link

sympy-bot commented Feb 21, 2020

🟠

Hi, I am the SymPy bot (v157). I've noticed that some of your commits add or delete files. Since this is sometimes done unintentionally, I wanted to alert you about it.

This is an experimental feature of SymPy Bot. If you have any feedback on it, please comment at sympy/sympy-bot#75.

The following commits add new files:

  • 9c19cc9:
    • sympy/matrices/tests/test_solvers.py

If these files were added/deleted on purpose, you can ignore this message.

# [ 1/(x + 1)]])

@XFAIL # dotprodsimp is not on by default in this function
def test_issue_17247_expression_blowup_32():
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can ignore the tests like expression_blowup.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you very much for the suggestion.

@mohitacecode
Copy link
Contributor

mohitacecode commented Feb 21, 2020

there are conflicts have you updated (git fetch upstream) the branch first before doing changes?

@asmeurer
Copy link
Member

I the past there have been issues with having two files with the same name in the repo. I don't know if those issues still exist, but it's worth checking if there are any problems, since we already have sympy/solvers/tests/test_solvers.py .

@sksingh1202
Copy link
Contributor Author

Thank you, @mohitacecode for mentioning, I hadn't pulled the changes before. Now I have pulled the changes from my fork to my local repository. Do I have to pull the changes from the sympy/sympy repository too? Can I update the pull request somehow or do I have to open a new pull request after fetching the changes? I am new to open source and it would be great if someone could help me out.
Thank you.

@sksingh1202
Copy link
Contributor Author

@asmeurer , thank you for pointing this out. I would check this and then possibly rename the file.

@sylee957
Copy link
Member

sylee957 commented Feb 22, 2020

There is already test_matrices in both the matrices and the assumptions test, but it does not have any problem for now.
I think that it should be same for here.

@mohitacecode
Copy link
Contributor

Thank you, @mohitacecode for mentioning, I hadn't pulled the changes before. Now I have pulled the changes from my fork to my local repository. Do I have to pull the changes from the sympy/sympy repository too? Can I update the pull request somehow or do I have to open a new pull request after fetching the changes? I am new to open source and it would be great if someone could help me out.
Thank you.

Try to pull the changes from sympy repository and when you will merge those changes you will get a merge conflict insympy/matrices/tests/test_matrices.py solve it and then proceed.

@sksingh1202
Copy link
Contributor Author

Thank you for your help and sorry for the delay as I was unable to give much time to this because of having exams now.

@sylee957
Copy link
Member

sylee957 commented Mar 9, 2020

Unfortunately, #18793 had arrived to the solution faster, so I may close this.

@sylee957 sylee957 closed this Mar 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants