Avoid exponential time complexity in codeprinter #23841
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
References to other Issues or PRs
Fixes #23839
Brief description of what is fixed or changed
There is no need to try to call a python string. Previously work was done to parenthesize the arguments even though it could be determined that this work was in vain.
Other comments
I wouldn't be surprised if it's possible to construct other pathogenic expressions exhibiting exponential runtime. But this fix should nevertheless be harmless.
cc @eschnett, does this help for your real world use case as well?
Release Notes
user_functions
to the printers.