Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

expand AddWithLimits expr using force hint #24002

Merged
merged 3 commits into from
Sep 2, 2022

Conversation

meganly
Copy link
Contributor

@meganly meganly commented Sep 1, 2022

References to other Issues or PRs

Implements feedback from #23996

Brief description of what is fixed or changed

Expand does not split sums or integrals if the summand is not commutative or the expression has infinite limits. The force=True hint can now be used to split the sum/integral regardless of the assumptions.

Other comments

Release Notes

  • concrete
    • Permitted expand to split sums and integrals with the force hint.

@sympy-bot
Copy link

sympy-bot commented Sep 1, 2022

Hi, I am the SymPy bot (v167). I'm here to help you write a release notes entry. Please read the guide on how to write release notes.

Your release notes are in good order.

Here is what the release notes will look like:

  • concrete
    • Permitted expand to split sums and integrals with the force hint. (#24002 by @meganly)

This will be added to https://github.com/sympy/sympy/wiki/Release-Notes-for-1.12.

Click here to see the pull request description that was parsed.
<!-- Your title above should be a short description of what
was changed. Do not include the issue number in the title. -->

#### References to other Issues or PRs
<!-- If this pull request fixes an issue, write "Fixes #NNNN" in that exact
format, e.g. "Fixes #1234" (see
https://tinyurl.com/auto-closing for more information). Also, please
write a comment on that issue linking back to this pull request once it is
open. -->
Implements feedback from #23996 

#### Brief description of what is fixed or changed
Expand does not split sums or integrals if the summand is not commutative or the expression has infinite limits.  The force=True hint can now be used to split the sum/integral regardless of the assumptions.

#### Other comments


#### Release Notes

<!-- Write the release notes for this release below between the BEGIN and END
statements. The basic format is a bulleted list with the name of the subpackage
and the release note for this PR. For example:

* solvers
  * Added a new solver for logarithmic equations.

* functions
  * Fixed a bug with log of integers.

or if no release note(s) should be included use:

NO ENTRY

See https://github.com/sympy/sympy/wiki/Writing-Release-Notes for more
information on how to write release notes. The bot will check your release
notes automatically to see if they are formatted correctly. -->

<!-- BEGIN RELEASE NOTES -->
* concrete
  * Permitted expand to split sums and integrals with the force hint.
<!-- END RELEASE NOTES -->

Update

The release notes on the wiki have been updated.

@github-actions
Copy link

github-actions bot commented Sep 1, 2022

Benchmark results from GitHub Actions

Lower numbers are good, higher numbers are bad. A ratio less than 1
means a speed up and greater than 1 means a slowdown. Green lines
beginning with + are slowdowns (the PR is slower then master or
master is slower than the previous release). Red lines beginning
with - are speedups.

Significantly changed benchmark results (PR vs master)

Significantly changed benchmark results (master vs previous release)

       before           after         ratio
     [41d90958]       [ed600afb]
     <sympy-1.11.1^0>                 
-         994±3μs          623±1μs     0.63  solve.TimeSparseSystem.time_linear_eq_to_matrix(10)
-        2.83±0ms         1.16±0ms     0.41  solve.TimeSparseSystem.time_linear_eq_to_matrix(20)
-     5.65±0.01ms      1.70±0.01ms     0.30  solve.TimeSparseSystem.time_linear_eq_to_matrix(30)

Full benchmark results can be found as artifacts in GitHub Actions
(click on checks at the top of the PR).

@oscarbenjamin
Copy link
Collaborator

It would be good to have a test that shows the effect of using force=True.

@meganly
Copy link
Contributor Author

meganly commented Sep 1, 2022

It would be good to have a test that shows the effect of using force=True.

Tests added 👍

@smichr smichr merged commit c56d975 into sympy:master Sep 2, 2022
@meganly meganly deleted the expand-addwithlimits-force branch September 2, 2022 17:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants