Add support for executing agent-local workloads #305
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I can't find the error message in the PR that rejects this.. maybe git's hiding the diff. |
|
As discussed I think if we put this behind a feature flag like Short version is nodes should default to not allowing this behavior and it should be explicitly opt-in to enable |
Workload deploy location can be specified with file:// or nats:// schemes. File-based deploy locations are treated as "agent-local" workload deploy requests, meaning the agent will attempt to resolve the file as an executable installed on its rootfs. File-based workload deploy requests can only be executed in sandbox mode.
kthomas
force-pushed
the
feat/agent-local-workloads
branch
from
665c64e
to
2d4014a
Compare
|
Closing in favor of #325 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR allows the workload deploy
locationto be specified using afile://ornats://URL scheme.File-based deploy locations are treated as "agent-local" workload deploy requests, meaning the agent will attempt to resolve the named file as an executable installed on its rootfs. File-based workload deploy requests can only be executed in sandbox mode.