Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: App can crash on resume (android) #1735

Closed
catch-21 opened this issue Apr 25, 2024 · 1 comment · Fixed by #1745
Closed

[Bug]: App can crash on resume (android) #1735

catch-21 opened this issue Apr 25, 2024 · 1 comment · Fixed by #1745
Assignees
Labels
bug Something isn't working
Milestone

Comments

@catch-21
Copy link
Contributor

catch-21 commented Apr 25, 2024

Describe the bug

Every once in a while, when I resume the app (from minimised, not fresh start) it immediately crashes before anything is displayed. I managed to catch logcat output for this:

04-25 14:59:53.982 28765 28765 E AndroidRuntime: Process: to.synonym.bitkit.wallet, PID: 28765
04-25 14:59:53.982 28765 28765 E AndroidRuntime: java.lang.RuntimeException: Unable to start activity ComponentInfo{to.synonym.bitkit.wallet/com.bitkit.MainActivity}: androidx.fragment.app.Fragment$InstantiationException: Unable to instantiate fragment com.swmansion.rnscreens.ScreenStackFragment: calling Fragment constructor caused an exception
04-25 14:59:53.982 28765 28765 E AndroidRuntime: 	at com.bitkit.MainActivity.onCreate(MainActivity.kt:22)
04-25 14:59:53.995  2183  2924 W ActivityTaskManager:   Force finishing activity to.synonym.bitkit.wallet/com.bitkit.MainActivity
04-25 14:59:54.021  5665  6142 D DigestGenerator: digest=============to.synonym.bitkit.walletjava.lang.RuntimeException: Unable to start activity ComponentInfo{to.synonym.bitkit.wallet/com.bitkit.MainActivity}: androidx.fragment.app.Fragment$InstantiationException: Unable to instantiate fragment com.swmansion.rnscreens.ScreenStackFragment: calling Fragment constructor caused an exception

This appears to be related to React Native. Looking at software-mansion/react-native-screens#17 (comment) we should be able to resolve it by changing our onCreate to super.onCreate(null);

Reproduce

  1. Leave Bitkit minimised for some time 15+ mins
  2. Resume app
  3. It may crash. Probably not but it can happen.

Screenshots / Recording

No response

Operating system

Android 13 TKQ1.220829.002

Bitkit version

c55c045

Log output

No response

@catch-21 catch-21 added bug Something isn't working triage This issue needs to be looked over by the team labels Apr 25, 2024
@pwltr pwltr self-assigned this Apr 25, 2024
@pwltr pwltr removed the triage This issue needs to be looked over by the team label Apr 26, 2024
@pwltr pwltr added this to the v.1 milestone Apr 26, 2024
pwltr added a commit that referenced this issue Apr 26, 2024
pwltr added a commit that referenced this issue Apr 26, 2024
pwltr added a commit that referenced this issue May 2, 2024
@catch-21
Copy link
Contributor Author

catch-21 commented May 9, 2024

Tested on 898a58a
Not seen this happen recently 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants