Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(settings): add app status screen in support #1518

Merged
merged 3 commits into from
Jan 27, 2024

Conversation

ovitrif
Copy link
Contributor

@ovitrif ovitrif commented Jan 25, 2024

Description

  • Added App Status screen to Settings > Support > App Status.
    Provides an overview of the user's Internet Connection, Bitcoin Node, LN node, Lightning channel, and Data backup.
  • Fixed a small duplicated check in backups by replacing it with the presumably intended key
    remoteLdkActivityBackupSyncRequiredremoteLdkBackupLastSyncRequired

Linked Issues/Tasks

Add Support → App Status screen (Part of Design v45)

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Refactoring (improving code without creating new functionality)

Tests

  • Detox test
  • Unit test
  • No test

Screenshot / Video

qemu-system-aarch64.2024-01-25.001435.mp4

QA Notes

The following states are supported:

  • Internet : 🟢 / 🔴
  • Bitcoin Node: 🟢 / 🟡 / 🔴
  • Lightning Node (LDK): 🟢 / 🔴
  • Lightning Connection (LN channel): 🟢 / 🟡 / 🔴
  • Full Backup: 🟢 / 🔴

Dev Notes

Open questions:

  • Should I remove translation strings for unsupported states?
    Since they're computed I left them in the initial impl. but given the app won't require them, they could be removed.
  • Any suggestions are more than welcome 🙏

@limpbrains
Copy link
Collaborator

Can you please add an e2e test for it?

@ovitrif
Copy link
Contributor Author

ovitrif commented Jan 25, 2024

Can you please add an e2e test for it?

Thank you for your request @limpbrains, I'll add an e2e test 🙇🏻

@ovitrif
Copy link
Contributor Author

ovitrif commented Jan 26, 2024

Can you please add an e2e test for it?

Done, went the easy option 🙈

@ovitrif ovitrif merged commit 36cd2f5 into master Jan 27, 2024
4 checks passed
@ovitrif ovitrif deleted the feat/support-app-status branch January 27, 2024 17:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants