Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(wallet): Re-Adds updateExchangeRates to setupOnChainWallet #1530

Merged
merged 1 commit into from
Feb 1, 2024

Conversation

coreyphillips
Copy link
Collaborator

@coreyphillips coreyphillips commented Feb 1, 2024

Description

  • The latest version of beignet removed exchangeRates so this re-adds updateExchangeRates to the setupOnChainWallet method.
  • Cleans up & Applies fix to lm.start function params so the electrum network is now read properly from beignet.
  • Upgrades beignet to 0.0.20.

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • Refactoring (improving code without creating new functionality)

Tests

  • No test

Cleans up & Applies fix to lm.start function params.
Upgrades beignet to 0.0.20.
@coreyphillips coreyphillips merged commit 8de8504 into master Feb 1, 2024
4 checks passed
@coreyphillips coreyphillips deleted the update-exchange-rates branch February 1, 2024 20:23
@pwltr
Copy link
Collaborator

pwltr commented Feb 2, 2024

Getting a warning every time the app starts:

 LOG  {"values": {"network": "regtest", "value": "exchangeRates", "walletName": "wallet0"}}
 ERROR  Error in setWalletData: [TypeError: Cannot convert undefined value to object]
 LOG  [TypeError: Cannot convert undefined value to object]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants