Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(wallet): Update Fee Estimates #1596

Merged
merged 1 commit into from
Mar 7, 2024
Merged

Conversation

coreyphillips
Copy link
Collaborator

Description

  • This prevents Beignet's fee estimate interval from interfering with Bitkit's internal check, preventing updates.
  • Adds refreshOnchainFeeEstimates method.
  • Moves refresh interval check in updateOnchainFeeEstimates method.

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • Refactoring (improving code without creating new functionality)

Tests

  • No test

Adds refreshOnchainFeeEstimates method.
Moves refresh interval check in updateOnchainFeeEstimates method.
@coreyphillips coreyphillips added bug Something isn't working beignet labels Mar 6, 2024
@coreyphillips coreyphillips added this to the Beignet milestone Mar 6, 2024
@coreyphillips coreyphillips requested a review from pwltr March 6, 2024 14:58
@coreyphillips coreyphillips self-assigned this Mar 6, 2024
@coreyphillips coreyphillips merged commit b456386 into master Mar 7, 2024
4 checks passed
@coreyphillips coreyphillips deleted the update-fee-estimates branch March 7, 2024 00:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
beignet bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants