Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: channel UI fixes #1612

Merged
merged 6 commits into from
Mar 20, 2024
Merged

fix: channel UI fixes #1612

merged 6 commits into from
Mar 20, 2024

Conversation

pwltr
Copy link
Collaborator

@pwltr pwltr commented Mar 19, 2024

Description

  • TotalBalance: don't include channel punishment reserve in total balance
  • QuickSetup: fix slider position & disabled button immediately after channel close
  • CustomSetup: fix not able to update channel duration
  • fix(transfer): fix transfer pending time not updated on first block confirmation
  • fix(lightning): avoid flashing different price after channel purchase confirmation
  • fix(receive): fix minimum amount for addtitional CJIT
  • fix(transfer): only show transfer to savings if tx has output to our wallet

Linked Issues/Tasks

https://app.asana.com/0/0/1204208728352470/1206703239419962/f

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Refactoring (improving code without creating new functionality)

Tests

  • Detox test
  • Unit test
  • No test

Copy link
Collaborator

@limpbrains limpbrains left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why are you removing DEFAULT_CHANNEL_DURATION everywhere ?

@pwltr
Copy link
Collaborator Author

pwltr commented Mar 20, 2024

why are you removing DEFAULT_CHANNEL_DURATION everywhere ?

Just a small cleanup, I just set it as a default for all the functions that use it. So we don't have to pass it explicitly if it's the same as default, can still pass and override it if needed

@pwltr pwltr merged commit 9f89ad5 into master Mar 20, 2024
4 checks passed
@pwltr pwltr deleted the fix/channel-fixes branch March 20, 2024 13:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants