Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update react-native-ldk and bump app build number #1623

Merged
merged 1 commit into from
Apr 9, 2024
Merged

Conversation

Jasonvdb
Copy link
Collaborator

Description

  • Updates react-native-ldk to include updated bindings to 0.0.121
  • Bumps build bumber

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Refactoring (improving code without creating new functionality)

Tests

  • Detox test
  • Unit test
  • No test

@Jasonvdb Jasonvdb requested a review from pwltr March 29, 2024 14:40
@pwltr
Copy link
Collaborator

pwltr commented Mar 29, 2024

@Jasonvdb Looks like sending to 0 amount invoices is broken in this build. Payment is failing with a routing error:

2024-03-29 17:35:49 ********NODE STATE********
NodeID: 034fcd0fa29a8ab02e5f98c02151c60e2c18f0801e0d68896fafe3228c579d3d24
Open channel:
Funding txid: 512df6df5cbdbd70287bc8e47c3532ff0fd65d26058a2f4e9863192fd8ded26c
Ready: YES
Usable: YES
Balance: 19598 sats
All claimable balances:
 [["amount_satoshis": 19598, "type": "ClaimableOnChannelClose"]]
RGS last sync time unavailable.
Connected peer: 03b9a456fb45d5ac98c02040d39aec77fa3eeb41fd22cf40b862b393bcfc43473a
Storage: /Users/phil/Library/Developer/CoreSimulator/Devices/0D859F2D-72AF-4C07-BB34-F24CA925E903/data/Containers/Data/Application/BFBD0987-0214-4849-A15E-0F34DC918592/Documents/ldk/wallet0bitcoinRegtestldkaccountv2
BackupClient setup: YES
Skip remote backups: NO
****************
2024-03-29 17:35:49 DEBUG (JS): nodeStateDump() success. 
2024-03-29 17:35:50 DEBUG (JS): listChannels() success. "Channels: 1"
2024-03-29 17:35:50 DEBUG (JS): readFromFile() success. "payments_sent.json"
2024-03-29 17:35:50 DEBUG (JS): claimableBalances() success. []
2024-03-29 17:35:51 DEBUG (JS): decode() success. 
2024-03-29 17:35:52 DEBUG (JS): addPeer() success. {"pubKey":"03b9a456fb45d5ac98c02040d39aec77fa3eeb41fd22cf40b862b393bcfc43473a","address":"35.233.47.252","port":9400,"timeout":1000}
2024-03-29 17:35:52 DEBUG (JS): ldk.pay() called with hard timeout of 60000ms
2024-03-29 17:35:52 DEBUG (JS): readFromFile() success. "peers.json"
2024-03-29 17:35:52 DEBUG (JS): listUsableChannels() success. "Usable channels: 1"
2024-03-29 17:35:52 INFO (LDK): Got route: path 0:
 node_id: 03b9a456fb45d5ac98c02040d39aec77fa3eeb41fd22cf40b862b393bcfc43473a, short_channel_id: 24906137392447488, fee_msat: 1000, cltv_expiry_delta: 80
 node_id: 030f6a49684e8f7b60dc965a072a09c3ed6cf4f61ffeac42828910ddfcf4777768, short_channel_id: 17592186044416001040, fee_msat: 500, cltv_expiry_delta: 24
 blinded_tail: None
 (lightning::routing::router 3059)
2024-03-29 17:35:52 DEBUG (LDK): Pushing new outbound HTLC with hash e60b7fd1bb32df64f44180e7b7b2c0d754acd44cab73409660ddd87f18236de9 for 1500 msat to peer (lightning::ln::channel 5863)
2024-03-29 17:35:52 INFO (LDK): Applying update to monitor 6cd2ded82f1963984e2f8a05265dd60fff32357ce4c87b2870bdbd5cdff62d51, bringing update_id from 30 to 31 with 1 change(s). (lightning::chain::channelmonitor 2752)
2024-03-29 17:35:52 DEBUG (LDK): Persistence of ChannelMonitorUpdate for channel 6cd2ded82f1963984e2f8a05265dd60fff32357ce4c87b2870bdbd5cdff62d51 in progress (lightning::chain::chainmonitor 793)
2024-03-29 17:35:52 DEBUG (LDK): ChannelMonitor update for 6cd2ded82f1963984e2f8a05265dd60fff32357ce4c87b2870bdbd5cdff62d51 in flight, holding messages until the update completes. (lightning::ln::channelmanager 3404)
2024-03-29 17:35:52 INFO (LDK): Sending payment with id e60b7fd1bb32df64f44180e7b7b2c0d754acd44cab73409660ddd87f18236de9 and hash e60b7fd1bb32df64f44180e7b7b2c0d754acd44cab73409660ddd87f18236de9 returned Err(PartialFailure { results: [Err(Client indicated a channel monitor update is in progress but not yet complete)], failed_paths_retry: None, payment_id: PaymentId([230, 11, 127, 209, 187, 50, 223, 100, 244, 65, 128, 231, 183, 178, 192, 215, 84, 172, 212, 76, 171, 115, 64, 150, 96, 221, 216, 127, 24, 35, 109, 233]) }) (lightning::ln::outbound_payment 937)
2024-03-29 17:35:52 DEBUG (JS): pay() success. 
2024-03-29 17:35:52 DEBUG (JS): ldk.pay() success (pending callbacks) Payment ID: 230,11,127,209,187,50,223,100,244,65,128,231,183,178,192,215,84,172,212,76,171,115,64,150,96,221,216,127,24,35,109,233
2024-03-29 17:35:52 DEBUG (JS): readFromFile() success. "payment_ids.json"
2024-03-29 17:35:52 DEBUG (JS): writeToFile() success. "payment_ids.json"
2024-03-29 17:35:52 DEBUG (LDK): Restored monitor updating in channel 6cd2ded82f1963984e2f8a05265dd60fff32357ce4c87b2870bdbd5cdff62d51 resulting in a commitment update and no RAA, with RAA first (lightning::ln::channel 4243)
2024-03-29 17:35:52 DEBUG (LDK): Handling UpdateHTLCs event in peer_handler for node 03b9a456fb45d5ac98c02040d39aec77fa3eeb41fd22cf40b862b393bcfc43473a with 1 adds, 0 fulfills, 0 fails for channel 6cd2ded82f1963984e2f8a05265dd60fff32357ce4c87b2870bdbd5cdff62d51 (lightning::ln::peer_handler 2118)
2024-03-29 17:35:52 DEBUG (LDK): Received a valid revoke_and_ack for channel 6cd2ded82f1963984e2f8a05265dd60fff32357ce4c87b2870bdbd5cdff62d51 with no reply necessary. Releasing monitor update. (lightning::ln::channel 3972)
2024-03-29 17:35:52 INFO (LDK): Applying update to monitor 6cd2ded82f1963984e2f8a05265dd60fff32357ce4c87b2870bdbd5cdff62d51, bringing update_id from 31 to 32 with 1 change(s). (lightning::chain::channelmonitor 2752)
2024-03-29 17:35:52 DEBUG (LDK): Persistence of ChannelMonitorUpdate for channel 6cd2ded82f1963984e2f8a05265dd60fff32357ce4c87b2870bdbd5cdff62d51 in progress (lightning::chain::chainmonitor 793)
2024-03-29 17:35:52 DEBUG (LDK): ChannelMonitor update for 6cd2ded82f1963984e2f8a05265dd60fff32357ce4c87b2870bdbd5cdff62d51 in flight, holding messages until the update completes. (lightning::ln::channelmanager 7002)
2024-03-29 17:35:52 DEBUG (LDK): Received valid commitment_signed from peer in channel 6cd2ded82f1963984e2f8a05265dd60fff32357ce4c87b2870bdbd5cdff62d51, updated HTLC state but awaiting a monitor update resolution to reply. (lightning::ln::channel 3542)
2024-03-29 17:35:52 INFO (LDK): Applying update to monitor 6cd2ded82f1963984e2f8a05265dd60fff32357ce4c87b2870bdbd5cdff62d51, bringing update_id from 32 to 33 with 1 change(s). (lightning::chain::channelmonitor 2752)
2024-03-29 17:35:52 DEBUG (LDK): Persistence of ChannelMonitorUpdate for channel 6cd2ded82f1963984e2f8a05265dd60fff32357ce4c87b2870bdbd5cdff62d51 in progress (lightning::chain::chainmonitor 793)
2024-03-29 17:35:52 DEBUG (LDK): ChannelMonitor update for 6cd2ded82f1963984e2f8a05265dd60fff32357ce4c87b2870bdbd5cdff62d51 in flight, holding messages until the update completes. (lightning::ln::channelmanager 6825)
2024-03-29 17:35:53 DEBUG (LDK): Restored monitor updating in channel 6cd2ded82f1963984e2f8a05265dd60fff32357ce4c87b2870bdbd5cdff62d51 resulting in no commitment update and an RAA, with commitment first (lightning::ln::channel 4243)
2024-03-29 17:35:53 DEBUG (LDK): Handling SendRevokeAndACK event in peer_handler for node 03b9a456fb45d5ac98c02040d39aec77fa3eeb41fd22cf40b862b393bcfc43473a for channel 6cd2ded82f1963984e2f8a05265dd60fff32357ce4c87b2870bdbd5cdff62d51 (lightning::ln::peer_handler 2143)
2024-03-29 17:35:53 DEBUG (LDK): Received valid commitment_signed from peer in channel 6cd2ded82f1963984e2f8a05265dd60fff32357ce4c87b2870bdbd5cdff62d51, updating HTLC state and responding with our own commitment_signed and a revoke_and_ack. (lightning::ln::channel 3559)
2024-03-29 17:35:53 INFO (LDK): Applying update to monitor 6cd2ded82f1963984e2f8a05265dd60fff32357ce4c87b2870bdbd5cdff62d51, bringing update_id from 33 to 34 with 2 change(s). (lightning::chain::channelmonitor 2752)
2024-03-29 17:35:53 DEBUG (LDK): Persistence of ChannelMonitorUpdate for channel 6cd2ded82f1963984e2f8a05265dd60fff32357ce4c87b2870bdbd5cdff62d51 in progress (lightning::chain::chainmonitor 793)
2024-03-29 17:35:53 DEBUG (LDK): ChannelMonitor update for 6cd2ded82f1963984e2f8a05265dd60fff32357ce4c87b2870bdbd5cdff62d51 in flight, holding messages until the update completes. (lightning::ln::channelmanager 6825)
2024-03-29 17:35:53 DEBUG (LDK): Restored monitor updating in channel 6cd2ded82f1963984e2f8a05265dd60fff32357ce4c87b2870bdbd5cdff62d51 resulting in a commitment update and an RAA, with RAA first (lightning::ln::channel 4243)
2024-03-29 17:35:53 DEBUG (LDK): Handling SendRevokeAndACK event in peer_handler for node 03b9a456fb45d5ac98c02040d39aec77fa3eeb41fd22cf40b862b393bcfc43473a for channel 6cd2ded82f1963984e2f8a05265dd60fff32357ce4c87b2870bdbd5cdff62d51 (lightning::ln::peer_handler 2143)
2024-03-29 17:35:53 DEBUG (LDK): Handling UpdateHTLCs event in peer_handler for node 03b9a456fb45d5ac98c02040d39aec77fa3eeb41fd22cf40b862b393bcfc43473a with 0 adds, 0 fulfills, 0 fails for channel 6cd2ded82f1963984e2f8a05265dd60fff32357ce4c87b2870bdbd5cdff62d51 (lightning::ln::peer_handler 2118)
2024-03-29 17:35:53 DEBUG (LDK): Received a valid revoke_and_ack for channel 6cd2ded82f1963984e2f8a05265dd60fff32357ce4c87b2870bdbd5cdff62d51 with no reply necessary. Releasing monitor update. (lightning::ln::channel 3972)
2024-03-29 17:35:53 INFO (LDK): Applying update to monitor 6cd2ded82f1963984e2f8a05265dd60fff32357ce4c87b2870bdbd5cdff62d51, bringing update_id from 34 to 35 with 1 change(s). (lightning::chain::channelmonitor 2752)
2024-03-29 17:35:53 DEBUG (LDK): Persistence of ChannelMonitorUpdate for channel 6cd2ded82f1963984e2f8a05265dd60fff32357ce4c87b2870bdbd5cdff62d51 in progress (lightning::chain::chainmonitor 793)
2024-03-29 17:35:53 DEBUG (LDK): ChannelMonitor update for 6cd2ded82f1963984e2f8a05265dd60fff32357ce4c87b2870bdbd5cdff62d51 in flight, holding messages until the update completes. (lightning::ln::channelmanager 7002)
2024-03-29 17:35:53 DEBUG (LDK): Restored monitor updating in channel 6cd2ded82f1963984e2f8a05265dd60fff32357ce4c87b2870bdbd5cdff62d51 resulting in no commitment update and no RAA, with RAA first (lightning::ln::channel 4243)
2024-03-29 17:35:53 INFO (LDK): Onion Error[from 03b9a456fb45d5ac98c02040d39aec77fa3eeb41fd22cf40b862b393bcfc43473a: amount_below_minimum(0x100b) htlc_msat(0000000001f40088)] Node indicated the HTLC amount was below the required minmum for the outbound channel (lightning::ln::onion_utils 720)
2024-03-29 17:35:53 DEBUG (LDK): Skipping application of a channel update from a payment failure. Channel 17592186044416001040 is enabled. (lightning::routing::gossip 358)
2024-03-29 17:35:53 DEBUG (LDK): Not able to penalize channel with SCID 24906137392447488 as we do not have graph info for it (likely a route-hint last-hop). (lightning::routing::scoring 1415)
2024-03-29 17:35:53 DEBUG (LDK): Not able to penalize channel with SCID 17592186044416001040 as we do not have graph info for it (likely a route-hint last-hop). (lightning::routing::scoring 1415)
2024-03-29 17:35:53 ERROR (LDK): Failed to find a route on retry, abandoning payment e60b7fd1bb32df64f44180e7b7b2c0d754acd44cab73409660ddd87f18236de9: LightningError {
    err: "Failed to find a path to the given destination",
    action: IgnoreError,
} (lightning::ln::outbound_payment 974)
2024-03-29 17:35:53 DEBUG (JS): processPendingHtlcForwards() success. 
2024-03-29 17:35:53 DEBUG (JS): readFromFile() success. "payment_ids.json"
2024-03-29 17:35:53 DEBUG (JS): nodeId() success. 
2024-03-29 17:35:53 DEBUG (JS): writeToFile() success. "payment_ids.json"
2024-03-29 17:35:53 DEBUG (JS): updateFees() success. {"onChainSweep":4,"maxAllowedNonAnchorChannelRemoteFee":40,"minAllowedAnchorChannelRemoteFee":1,"minAllowedNonAnchorChannelRemoteFee":0,"anchorChannelFee":1,"nonAnchorChannelFee":2,"channelCloseMinimum":1}
2024-03-29 17:35:53 DEBUG (JS): addPeer() success. {"pubKey":"03b9a456fb45d5ac98c02040d39aec77fa3eeb41fd22cf40b862b393bcfc43473a","address":"35.233.47.252","port":9400,"timeout":1000}
2024-03-29 17:35:53 DEBUG (JS): readFromFile() success. "peers.json"
2024-03-29 17:35:53 DEBUG (JS): writeToFile() success. "unconfirmed_transactions.json"

@Jasonvdb
Copy link
Collaborator Author

@Jasonvdb Looks like sending to 0 amount invoices is broken in this build. Payment is failing with a routing error:

@pwltr weird I tested this a few times in the example app because it was an existing bug. This is iOS right? And what were you paying?

@pwltr
Copy link
Collaborator

pwltr commented Mar 30, 2024

@Jasonvdb This was Bitkit (iOS) -> Bitkit (iOS) with anywhere from 100 - 500, the E2E test we have in place is iOS -> LND sending 111

@Jasonvdb Jasonvdb merged commit 1fde305 into master Apr 9, 2024
4 checks passed
@Jasonvdb Jasonvdb deleted the ldk-vbump branch April 9, 2024 16:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants