Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(backup): add boosts & transfers to backup #2128

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

pwltr
Copy link
Collaborator

@pwltr pwltr commented Aug 9, 2024

Description

Adds boostedTransactions and transfers from wallet state to backup & restore.

Currently there is an issue with restoring boosted transactions, onchain activity is restored before boosted transactions are in state.

Linked Issues/Tasks

Closes #1844 #1868

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Refactoring (improving code without creating new functionality)

Tests

  • Detox test
  • Unit test
  • No test

@@ -242,6 +242,66 @@ export const isObjPartialMatch = (
});
};

export const deepCompareStructure = (
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we have lodash, maybe just use it?

@limpbrains
Copy link
Collaborator

I think we should merge this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: Restored wallet splits Boosted CPFP transactions into separate activities
2 participants