Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(wallet): wipe all data on ToS screen #2200

Merged
merged 1 commit into from
Sep 5, 2024
Merged

fix(wallet): wipe all data on ToS screen #2200

merged 1 commit into from
Sep 5, 2024

Conversation

pwltr
Copy link
Collaborator

@pwltr pwltr commented Sep 5, 2024 •
edited
Loading

Description

Wipe all data on ToS screen to prevent inflight updates to populate redux state after wallet reset.

Reverts change:

bitkit/src/screens/Onboarding/TermsOfUse.tsx

Line 40 in afd07c5

await wipeKeychain();

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Refactoring (improving code without creating new functionality)

Tests

  • Detox test
  • Unit test
  • No test

@pwltr pwltr merged commit dd9d00d into master Sep 5, 2024
7 checks passed
@pwltr pwltr deleted the fix/revert-tos-wipe branch September 5, 2024 15:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@limpbrains limpbrains limpbrains approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pwltr @limpbrains