Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: switch from @synonymdev/react-native-keychain to react-native-keychain-manager #2279

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from
Draft
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
31 changes: 25 additions & 6 deletions ios/Podfile.lock
Original file line number Diff line number Diff line change
Expand Up @@ -1740,8 +1740,27 @@ PODS:
- ReactCommon/turbomodule/bridging
- ReactCommon/turbomodule/core
- Yoga
- RNKeychain (8.2.2):
- RNKeychainManager (1.2.1):
- DoubleConversion
- glog
- hermes-engine
- RCT-Folly (= 2024.01.01.00)
- RCTRequired
- RCTTypeSafety
- React-Core
- React-debug
- React-Fabric
- React-featureflags
- React-graphics
- React-ImageManager
- React-NativeModulesApple
- React-RCTFabric
- React-rendererdebug
- React-utils
- ReactCodegen
- ReactCommon/turbomodule/bridging
- ReactCommon/turbomodule/core
- Yoga
- RNLocalize (3.0.2):
- React-Core
- RNNotifee (7.8.2):
Expand Down Expand Up @@ -1968,7 +1987,7 @@ DEPENDENCIES:
- RNDeviceInfo (from `../node_modules/react-native-device-info`)
- RNFS (from `../node_modules/react-native-fs`)
- RNGestureHandler (from `../node_modules/react-native-gesture-handler`)
- "RNKeychain (from `../node_modules/@synonymdev/react-native-keychain`)"
- RNKeychainManager (from `../node_modules/react-native-keychain-manager`)
- RNLocalize (from `../node_modules/react-native-localize`)
- "RNNotifee (from `../node_modules/@notifee/react-native`)"
- RNPermissions (from `../node_modules/react-native-permissions`)
Expand Down Expand Up @@ -2158,8 +2177,8 @@ EXTERNAL SOURCES:
:path: "../node_modules/react-native-fs"
RNGestureHandler:
:path: "../node_modules/react-native-gesture-handler"
RNKeychain:
:path: "../node_modules/@synonymdev/react-native-keychain"
RNKeychainManager:
:path: "../node_modules/react-native-keychain-manager"
RNLocalize:
:path: "../node_modules/react-native-localize"
RNNotifee:
Expand Down Expand Up @@ -2274,7 +2293,7 @@ SPEC CHECKSUMS:
RNDeviceInfo: b899ce37a403a4dea52b7cb85e16e49c04a5b88e
RNFS: 4ac0f0ea233904cb798630b3c077808c06931688
RNGestureHandler: e80cae4246813ee7f667a2552012a6b7da5550a1
RNKeychain: 35f92386e7f8548e3e60e7441121afbe8c62d8e4
RNKeychainManager: 5498b86c5af4cc6870a07dd0f996565371802590
RNLocalize: dbea38dcb344bf80ff18a1757b1becf11f70cae4
RNNotifee: 8e2d3df3f0e9ce8f5d1fe4c967431138190b6175
RNPermissions: 2c0eec471f4de66d04d226c339898d10a6e123c4
Expand All @@ -2292,6 +2311,6 @@ SPEC CHECKSUMS:
Yoga: 2a45d7e59592db061217551fd3bbe2dd993817ae
ZXingObjC: 8898711ab495761b2dbbdec76d90164a6d7e14c5

PODFILE CHECKSUM: b1ff2276b558626bd07bddd66e26b06f3fc76609
PODFILE CHECKSUM: cb153cb4a39e6c92c8b869eafab65a4bba7b869f

COCOAPODS: 1.15.2
2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -49,7 +49,6 @@
"@synonymdev/blocktank-lsp-http-client": "1.5.0",
"@synonymdev/feeds": "3.0.0",
"@synonymdev/ledger": "0.0.5",
"@synonymdev/react-native-keychain": "8.2.2",
"@synonymdev/react-native-ldk": "0.0.153",
"@synonymdev/react-native-lnurl": "0.0.10",
"@synonymdev/react-native-pubky": "^0.3.0",
Expand Down Expand Up @@ -94,6 +93,7 @@
"react-native-haptic-feedback": "2.2.0",
"react-native-image-picker": "7.1.2",
"react-native-keyboard-accessory": "0.1.16",
"react-native-keychain-manager": "^1.2.1",
"react-native-localize": "3.0.2",
"react-native-mmkv": "2.12.2",
"react-native-modal": "13.0.1",
Expand Down
2 changes: 1 addition & 1 deletion src/utils/keychain.ts
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
import Keychain from '@synonymdev/react-native-keychain';
import Keychain from 'react-native-keychain-manager';
import { err, ok, Result } from '@synonymdev/result';
import { IResponse } from './types';

Expand Down
2 changes: 1 addition & 1 deletion src/utils/lightning/index.ts
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
import { EmitterSubscription } from 'react-native';
import Keychain from '@synonymdev/react-native-keychain';
import Keychain from 'react-native-keychain-manager';
import * as bitcoin from 'bitcoinjs-lib';
import RNFS from 'react-native-fs';
import { err, ok, Result } from '@synonymdev/result';
Expand Down
16 changes: 8 additions & 8 deletions yarn.lock
Original file line number Diff line number Diff line change
Expand Up @@ -4931,13 +4931,6 @@ __metadata:
languageName: node
linkType: hard

"@synonymdev/react-native-keychain@npm:8.2.2":
version: 8.2.2
resolution: "@synonymdev/react-native-keychain@npm:8.2.2"
checksum: 90c16a7caec3ae648c2c9af3d87da4e7bd425719e528d2793345b73f4757ec6aeacbdb4126b77e6f3b4237d8e734d35d7769e7a2fda54caaaea8b97dc699f558
languageName: node
linkType: hard

"@synonymdev/react-native-ldk@npm:0.0.153":
version: 0.0.153
resolution: "@synonymdev/react-native-ldk@npm:0.0.153"
Expand Down Expand Up @@ -6605,7 +6598,6 @@ __metadata:
"@synonymdev/blocktank-lsp-http-client": 1.5.0
"@synonymdev/feeds": 3.0.0
"@synonymdev/ledger": 0.0.5
"@synonymdev/react-native-keychain": 8.2.2
"@synonymdev/react-native-ldk": 0.0.153
"@synonymdev/react-native-lnurl": 0.0.10
"@synonymdev/react-native-pubky": ^0.3.0
Expand Down Expand Up @@ -6675,6 +6667,7 @@ __metadata:
react-native-haptic-feedback: 2.2.0
react-native-image-picker: 7.1.2
react-native-keyboard-accessory: 0.1.16
react-native-keychain-manager: ^1.2.1
react-native-localize: 3.0.2
react-native-mmkv: 2.12.2
react-native-modal: 13.0.1
Expand Down Expand Up @@ -14351,6 +14344,13 @@ __metadata:
languageName: node
linkType: hard

"react-native-keychain-manager@npm:^1.2.1":
version: 1.2.1
resolution: "react-native-keychain-manager@npm:1.2.1"
checksum: c2969e9fb233200af0a4fd30ab41b55b4715da1bad4f4c7506471f3e05edb86104b1e31e0c3aefb70fa2335c09bfbb61a89335f70957e3cc5b58ff669e7d2716
languageName: node
linkType: hard

"react-native-localize@npm:3.0.2":
version: 3.0.2
resolution: "react-native-localize@npm:3.0.2"
Expand Down
Loading