Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: various e2e fixes #2280

Merged
merged 1 commit into from
Oct 7, 2024
Merged

fix: various e2e fixes #2280

merged 1 commit into from
Oct 7, 2024

Conversation

limpbrains
Copy link
Collaborator

@limpbrains limpbrains commented Oct 3, 2024 •
edited
Loading

Description

  • instead of waiting for the port to be open, wait for admin.macaroon to appear to determine that LND has started. This works better for the Android tests
  • remove depricated yarn arguments
  • device.launchApp() does not actually restart the app, you need to pass newInstance: true. But I'm using launchAndWait(). Looks like the channel.e2e.js test is now more stable

Linked Issues/Tasks

Type of change

Bug fix

Tests

Detox test

@limpbrains limpbrains force-pushed the e2e-fixes branch 6 times, most recently from f863d01 to 7e2b7c4 Compare October 7, 2024 09:44
@limpbrains limpbrains marked this pull request as ready for review October 7, 2024 14:32
@limpbrains limpbrains requested a review from pwltr October 7, 2024 14:33
@limpbrains limpbrains merged commit 3f97d11 into master Oct 7, 2024
7 checks passed
@limpbrains limpbrains deleted the e2e-fixes branch October 7, 2024 14:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pwltr pwltr pwltr approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@limpbrains @pwltr