New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump controller runtime to 0.17 #124

Merged

ChunyiLyu merged 1 commit into main from bump-controller-runtime

May 14, 2024

Member

ChunyiLyu commented May 14, 2024

There were some changes needed for our unit test continue to work:

set GVK in Work test explicitly, this is because controller runtime no long set TypeMeta for objects unless it's unstructured, see: ⚠️ Fakeclient: Only set TypeMeta for unstructured kubernetes-sigs/controller-runtime#2633
Some changes in error messages
Regenerate manager fakes


          Bump controller runtime to 0.17

bec708e

- Set GVK in work test explicitly
- Regenerate manager fakes
- Update expected event message

abangser approved these changes

View reviewed changes

ChunyiLyu merged commit 023d8e2 into main

8 checks passed

ChunyiLyu deleted the bump-controller-runtime branch

May 14, 2024 13:26

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet