Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Port Insight distance metrics #128

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

Port Insight distance metrics #128

wants to merge 5 commits into from

Conversation

Hilly12
Copy link
Contributor

@Hilly12 Hilly12 commented Sep 15, 2021 •
edited
Loading

  • Make distance metrics use insight
  • Make fairness scorer use insight through stat_distance

@Hilly12 Hilly12 marked this pull request as draft September 15, 2021 07:54
@bogdansurdu bogdansurdu linked an issue Sep 16, 2021 that may be closed by this pull request
Integrating insight into fairlens #127
Open
@sonarcloud
Copy link

sonarcloud bot commented Sep 16, 2021

Please retry analysis of this Pull-Request directly on SonarCloud.

@Hilly12 Hilly12 marked this pull request as ready for review September 16, 2021 14:10
@sonarcloud
Copy link

sonarcloud bot commented Sep 16, 2021

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

80.9% 80.9% Coverage
0.0% 0.0% Duplication

@simonhkswan simonhkswan self-requested a review September 17, 2021 09:44
@codecov
Copy link

codecov bot commented Sep 17, 2021 •
edited
Loading

Codecov Report

Merging #128 (009d32c) into main (432b120) will increase coverage by 0.80%.
The diff coverage is 76.92%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #128      +/-   ##
==========================================
+ Coverage   74.16%   74.97%   +0.80%     
==========================================
  Files          15       15              
  Lines         871      867       -4     
  Branches      186      188       +2     
==========================================
+ Hits          646      650       +4     
+ Misses        181      170      -11     
- Partials       44       47       +3
Flag Coverage Δ
unittests 74.97% <76.92%> (+0.80%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/fairlens/metrics/unified.py 55.69% <66.66%> (+8.75%) ⬆️
src/fairlens/metrics/distance.py 92.37% <93.33%> (+9.47%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 432b120...009d32c. Read the comment docs.

@sonarcloud
Copy link

sonarcloud bot commented Sep 17, 2021

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

80.9% 80.9% Coverage
0.0% 0.0% Duplication

@simonhkswan simonhkswan linked an issue Sep 27, 2021 that may be closed by this pull request
Import the insight package into fairlens and remove any duplicated code #110
Open
@simonhkswan simonhkswan removed their request for review April 4, 2024 11:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@Hilly12 Hilly12

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Integrating insight into fairlens Import the insight package into fairlens and remove any duplicated code
1 participant
@Hilly12