Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pull request templates #132

Merged
merged 6 commits into from
Apr 27, 2022
Merged

Pull request templates #132

merged 6 commits into from
Apr 27, 2022

Conversation

bogdansurdu
Copy link
Contributor

@bogdansurdu bogdansurdu commented Sep 16, 2021

This pull request will add a template for general Pull Requests.

Closes #129

@sonarcloud
Copy link

sonarcloud bot commented Sep 16, 2021

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@codecov
Copy link

codecov bot commented Dec 8, 2021

Codecov Report

Merging #132 (0f18191) into main (d77e1a2) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #132   +/-   ##
=======================================
  Coverage   76.03%   76.03%           
=======================================
  Files          16       16           
  Lines        1014     1014           
  Branches      234      234           
=======================================
  Hits          771      771           
  Misses        194      194           
  Partials       49       49           
Flag Coverage Δ
unittests 76.03% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d77e1a2...0f18191. Read the comment docs.

@sonarcloud
Copy link

sonarcloud bot commented Dec 8, 2021

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

Optional PR templates are only supported through query parameters at the moment. Sticking to just one PR template for now.
Copy link
Contributor

@simonhkswan simonhkswan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Distilled the templates down to one default PR template as this is better supported by github at the moment.

@sonarcloud
Copy link

sonarcloud bot commented Apr 27, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@simonhkswan simonhkswan merged commit 6b864ec into main Apr 27, 2022
@delete-merged-branch delete-merged-branch bot deleted the pull-request-template branch April 27, 2022 13:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[ISSUE] Templates for Pull Requests
2 participants