We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Describe the issue
in https://github.com/syoyo/tinygltf/blob/release/tiny_gltf.h
bool TinyGLTF::LoadBinaryFromMemory(...) { ... // Extract JSON string. std::string jsonString(reinterpret_cast<const char *>(&bytes[20]), chunk0_length);
LoadBinaryFromMemory creates a copy of JSON block, but this copy is never used: https://github.com/search?q=repo%3Asyoyo/tinygltf%20jsonString&type=code
To Reproduce
NA
Expected behaviour
Wasteless code.
Screenshots
Additional context
The text was updated successfully, but these errors were encountered:
Good find! The code should be safely deleted
Sorry, something went wrong.
Closed via 4b9cfc8
Remove unused code. Fixes syoyo#454
4b9cfc8
No branches or pull requests
Describe the issue
in https://github.com/syoyo/tinygltf/blob/release/tiny_gltf.h
LoadBinaryFromMemory creates a copy of JSON block, but this copy is never used: https://github.com/search?q=repo%3Asyoyo/tinygltf%20jsonString&type=code
To Reproduce
NA
Expected behaviour
Wasteless code.
Screenshots
NA
Additional context
NA
The text was updated successfully, but these errors were encountered: