Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Multi-line description breaks exports #5

Closed
5 tasks done
tankerkiller125 opened this issue Jun 18, 2024 · 4 comments
Closed
5 tasks done

Multi-line description breaks exports #5

tankerkiller125 opened this issue Jun 18, 2024 · 4 comments
Assignees
Labels
🕷️ bug Something isn't working good first issue Good for newcomers

Comments

@tankerkiller125
Copy link
Contributor

First Check

  • This is not a feature request
  • I added a very descriptive title to this issue.
  • I used the GitHub search to find a similar issue and didn't find it.
  • I searched the documentation, with the integrated search.
  • I already read the docs and didn't find an answer.

Homebox Version

0.10.3

What is the issue you are experiencing?

Multiline descriptions breaks the export file.

Originally reported by @Saturo78 in hay-kot/homebox#914

How can the maintainer reproduce the issue?

Use a multi-line description and then export the file.

Deployment

Docker (Linux)

Deployment Details

No response

@tankerkiller125 tankerkiller125 added the 🕷️ bug Something isn't working label Jun 18, 2024
@katosdev katosdev added the good first issue Good for newcomers label Jun 19, 2024
@icanc0
Copy link
Contributor

icanc0 commented Jun 22, 2024

Can someone assign me to this? seems like a relatively trivial fix

@icanc0
Copy link
Contributor

icanc0 commented Jun 23, 2024

I can't reproduce this issue here.

image
image

The item exports and imports just fine.

image
image

Both TSV/CSV imports are fine in Google Sheets.

image
Works fine with Excel Web too... Although it only accepts CSV.

I'm 99% certain that this issue is fixed by giving the file the correct extension, as described as in #3.

@icanc0
Copy link
Contributor

icanc0 commented Jun 26, 2024

We can close this after #54 is merged, seems like the TSV/CSV confusion caused the bug.

@tankerkiller125
Copy link
Contributor Author

#54 has been merged, and I also can no longer replicate this issue with the latest version of master with the patches.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🕷️ bug Something isn't working good first issue Good for newcomers
Projects
Status: Done
Development

No branches or pull requests

3 participants