Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix TSVs actually being CSVs #3

Closed
5 tasks done
tankerkiller125 opened this issue Jun 17, 2024 · 4 comments · Fixed by #19 or #54
Closed
5 tasks done

Fix TSVs actually being CSVs #3

tankerkiller125 opened this issue Jun 17, 2024 · 4 comments · Fixed by #19 or #54
Assignees
Labels
🕷️ bug Something isn't working

Comments

@tankerkiller125
Copy link
Contributor

First Check

  • This is not a feature request
  • I added a very descriptive title to this issue.
  • I used the GitHub search to find a similar issue and didn't find it.
  • I searched the documentation, with the integrated search.
  • I already read the docs and didn't find an answer.

Homebox Version

0.10.3

What is the issue you are experiencing?

Originally reported in hay-kot/homebox#910 by @betapictoris the exported files are comma seperated, but have the TSV extension.

How can the maintainer reproduce the issue?

  1. Export BOM
  2. Examine the file in a text editor

Deployment

Docker (Linux)

Deployment Details

No response

@tankerkiller125 tankerkiller125 added the 🕷️ bug Something isn't working label Jun 17, 2024
@katosdev katosdev self-assigned this Jun 18, 2024
@betapictoris
Copy link

Thanks for working on this!

@icanc0
Copy link
Contributor

icanc0 commented Jun 23, 2024

This issue remains unfixed, there's another export function that calls on /api/v1/items/export. I'm going to fix it along with #5.

@tankerkiller125 @katosdev is there a reason why we had both TSV and CSV for different types of exports?

image

image above shows a call to /api/v1/items/export

image

image above shows both export methods

Seems like the file formats are still reversed, here's the result from the current main branch:
image

@katosdev
Copy link
Contributor

@tankerkiller125 @katosdev is there a reason why we had both TSV and CSV for different types of exports?

Honestly, no idea why both are there. Makes sense to switch to just CSV I believe 👍🏻

@icanc0
Copy link
Contributor

icanc0 commented Jun 24, 2024

Honestly, no idea why both are there. Makes sense to switch to just CSV I believe 👍🏻

Alright, gonna do a quick PR so i get used to the process again.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🕷️ bug Something isn't working
Projects
Status: Done
4 participants