Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Call 'ProcessQueryAndSetStatusFlags' check even if query failed #3327

Closed
3 tasks done
JavierJF opened this issue Mar 1, 2021 · 0 comments · Fixed by #3328
Closed
3 tasks done

Call 'ProcessQueryAndSetStatusFlags' check even if query failed #3327

JavierJF opened this issue Mar 1, 2021 · 0 comments · Fixed by #3328

Comments

@JavierJF
Copy link
Collaborator

JavierJF commented Mar 1, 2021

  • A clear description of the issue

Right ProcessQueryAndSetStatusFlags is just executed if a query is correctly executed. Instead this check should be performed each time a query is performed, not just in case it succeed.

  • ProxySQL version

v2.0.18
v2.1.1

  • OS version
NAME="Arch Linux"
PRETTY_NAME="Arch Linux"
ID=arch
BUILD_ID=rolling
JavierJF added a commit that referenced this issue Mar 1, 2021
@JavierJF
Closes #3327: Moved call to 'ProcessQueryAndSetStatusFlags' to 'MySQL…
c0547d0 
…_Session::RequestEnd'
JavierJF added a commit that referenced this issue Mar 1, 2021
@JavierJF
Added regression test for #3327 to check that 'ProcessQueryAndSetStat…
de8d2b2 
…usFlags' is properly call after a failed query
JavierJF added a commit that referenced this issue Mar 1, 2021
@JavierJF
Added regression test for #3327 to check that 'ProcessQueryAndSetStat…
ee7420c 
…usFlags' is properly call after a failed query
@JavierJF JavierJF mentioned this issue Mar 1, 2021
Merged
renecannao added a commit that referenced this issue Mar 3, 2021
@renecannao
Merge pull request #3328 from sysown/v2.1.1-3327
5455b7d 
Closes #3327: Call 'ProcessQueryAndSetStatusFlags' check even if query failed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Closes #3327: Call 'ProcessQueryAndSetStatusFlags' check even if query failed sysown/proxysql
1 participant
@JavierJF