Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Track sql_mode #509

Closed
renecannao opened this issue Mar 7, 2016 · 4 comments
Closed

Track sql_mode #509

renecannao opened this issue Mar 7, 2016 · 4 comments
Labels
CONNECTION POOL MYSQL PROTOCOL
Milestone
Truls

Comments

@renecannao
Copy link
Contributor

WHY

Currently proxysql doesn't track SET SESSION sql_mode=
@renecannao renecannao added this to the Truls milestone Mar 7, 2016
renecannao added a commit that referenced this issue Dec 6, 2016
@renecannao
Added the tracking of some variables
902e9d6 
Added the tracking of these variables:
* sql_mode #509
* sql_log_bin #815
* time_zone #816
@icinga-migration icinga-migration mentioned this issue Jan 17, 2017
Closed
@leeparayno
Copy link

leeparayno commented Feb 14, 2017 •
edited
Loading

Looks like the tracking of sql_mode is going to be in place for 1.40 according to the commit 902e9d6 from Dec 6, 2016.

@renecannao When do you think 1.4.0 will be released?

I'm trying to investigate what appears to be a sql_mode issue with queries from our Rails app that are going through ProxySQL and returning a connection error for ONLY_FULL_GROUP_BY on queries connecting to 5.7 backends, but I think without this additional tracking/logging the information about sql_mode won't be surfaced back through ProxySQL.

@renecannao
Copy link
Contributor Author

@leeparayno : there is no official release date yet.
The current 1.4.0 branch has small differences compared to 1.3.x , and at it is right now should be considered reasonably stable. Would you consider testing it?
Thanks

@leeparayno
Copy link

@renecannao Yes I would like to see how sql_mode behaves there.

Separately, is there any way to set the sql_mode explicitly on every connection going to the backend?

@renecannao
Copy link
Contributor Author

Yes, it is possible setting global variable mysql-init_connect .
Note that mysql-init_connect behaves incorrectly with prepared statements: this bug is already fixed and a new version will be released tomorrow

@renecannao renecannao mentioned this issue Feb 17, 2017
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
CONNECTION POOL MYSQL PROTOCOL
Projects
None yet
Milestone
Truls
Development

No branches or pull requests
2 participants
@leeparayno @renecannao