Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add option autocommit_false_not_reusable #1144

Merged
merged 1 commit into from
Aug 18, 2017

Conversation

everpcpc
Copy link
Contributor

another way to handle #1044
cc @MOON-CLJ

@renecannao
Copy link
Contributor

Thank you @everpcpc !
The commit looks good to me. Merging it.
Nonetheless, I think there are too many variables to control and a lot of edge cases: this is not intuitive for regular users.
A more elegant solution is needed, and I think the idea behind #955 is the correct one.

Thanks

@renecannao renecannao merged commit 75bb9b7 into sysown:v1.4.2 Aug 18, 2017
@everpcpc everpcpc deleted the autocommit branch August 18, 2017 11:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants