support more mysql system variables to keep mulitplexing enabled #1922
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Automated message: PR pending admin approval for build testing |
|
@ahaha-zhang : would it be possible to have some unit test for the code in this PR? |
|
@renecannao, I've added the unit test code for this PR. Thank you for your review :) |
… auto_increment token
renecannao
added a commit
that referenced
this pull request
Mar 22, 2019
support more mysql system variables to keep mulitplexing enabled Added variable mysql-keep_multiplexing_variables
renecannao
added a commit
that referenced
this pull request
Mar 22, 2019
|
OK, My pleasure:) |
renecannao
added a commit
that referenced
this pull request
Apr 23, 2019
Dieken
pushed a commit
to Dieken/proxysql
that referenced
this pull request
May 13, 2019
(cherry picked from commit 58d77e4)
renecannao
added a commit
that referenced
this pull request
Aug 10, 2019
Port to 1.4.x of commit 58d77e4
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi, Rene:
I recently �debug why some connections were not multiplexing. I find that there are too many types of query digests, such as "select @@session.xxxx/select @@xxxx as yyy/select @@A,@b,@c", kinds of connector init-SQL and creative developers:).
I notice that there are only 2 exceptions hardcoded "select @@version/tx_isolation" that don't disable multiplexing. The other way is to configure a query rule. However, I have to configure too many kinds of query digests. Being able to configure more variables and support more kinds of queries is definitely preferred.
A new global variable in proxysql, default "tx_isolation,version":
mysql> show variables like 'mysql-keep_multiplexing_variables';
+-----------------------------------+----------------------+
| Variable_name | Value |
+-----------------------------------+----------------------+
| mysql-keep_multiplexing_variables | tx_isolation,version |
+-----------------------------------+----------------------+
1 row in set (0.00 sec)
A new function
bool MySQL_Connection::IsKeepMultiplexEnabledVariables(char *query_digest_text)
Support more kinds of query_digest_text:
select @@Version,@@tx_isolation;
select @@Version as aaa,@@tx_isolation as bbb,......;