Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

V2.0.12 Fix set global variables error #2767

Merged
merged 1 commit into from
May 11, 2020
Merged

Conversation

alpes214
Copy link
Contributor

@alpes214 alpes214 commented May 8, 2020

Description:
Fixes the issue #2741

Test:
set statement changes default_% variables as expected without an error.

mysql> select * from global_variables where variable_name like '%character%';
+----------------------------------------+----------------+
| variable_name                          | variable_value |
+----------------------------------------+----------------+
| mysql-default_character_set_results    | utf8mb4        |
| mysql-default_character_set_connection | utf8mb4        |
| mysql-default_character_set_client     | utf8mb4        |
| mysql-default_character_set_database   | utf8mb4        |
+----------------------------------------+----------------+
4 rows in set (0.00 sec)

mysql> set mysql-default_character_set_client='utf8';
Query OK, 1 row affected (0.00 sec)

mysql> set mysql-default_character_set_connection='utf8';
Query OK, 1 row affected (0.00 sec)

mysql> select * from global_variables where variable_name like '%character%';
+----------------------------------------+----------------+
| variable_name                          | variable_value |
+----------------------------------------+----------------+
| mysql-default_character_set_results    | utf8mb4        |
| mysql-default_character_set_connection | utf8           |
| mysql-default_character_set_client     | utf8           |
| mysql-default_character_set_database   | utf8mb4        |
+----------------------------------------+----------------+
4 rows in set (0.00 sec)

@renecannao
Copy link
Contributor

It looks good to me.
Please create a similar PR for 2.1

@alpes214 alpes214 changed the title Fix set global variables error V2.0.12 Fix set global variables error May 11, 2020
@renecannao renecannao merged commit c518638 into v2.0.12 May 11, 2020
@renecannao renecannao deleted the v2.0.12-global-vars branch June 15, 2020 19:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants