fix unquoted table name leading to sql errors #2836
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In lib/MySQL_Protocol.cpp MySQL_Protocol::generate_COM_QUERY_from_COM_FIELD_LIST line 2315 there is a query:
char *qt = (char *)"SELECT * FROM %s WHERE 1=0";
The table name here is unquoted, leading to SQL errors if the table name is a keyword or somewhat non-normalized, like:
2020-05-28 15:36:16 MySQL_Session.cpp:4333:handler(): [WARNING] Error during query on (1,sql1,3306): 1064, You have an error in your SQL syntax; check the manual that corresponds to your MySQL server version for the right syntax to use near 'groups WHERE 1=0' at line 1