Disabling variables from MySQL_Variables #2866
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Extended `mysql_variable_st` to add a new variable `is_global_variable`. Using this variable we define the global variables. Modified `mysql_tracked_variables[]` to also specify `is_global_variable`. Removed `default_charset` from `MySQL_Threads_Handler::variables` to use `mysql_tracked_variables[]` instead. Removed `default_charset` also from `mysql_thread_variables_names[]`. Fixed `MySQL_Threads_Handler::get_variable_string()` : it was *not* returning `mysql-default_` variables. `MySQL_Threads_Handler::set_variable()` adds `mysql-default_` variables only if `is_global_variable` is set. In `MySQL_Threads_Handler::set_variable()` replaced a `strcasecmp()` with `strcmp()` for `mysql-default_` variables. `MySQL_Threads_Handler::get_variables_list()` returns only `mysql-default_` variables with `is_global_variable` enabled. `MySQL_Threads_Handler::has_variable()` for `mysql-default_` variables returns true only if variable has `is_global_variable` enabled. `MySQL_Thread::refresh_variables()` does not refresh `mysql-default_` variables if `is_global_variable` is not enabled. `MySQL_Thread::MySQL_Thread()` initializes to NULL all `mysql_thread___default_variables[]` variables. Completely disabled in `ProxySQL_Admin::flush_mysql_variables___database_to_runtime()` the logic applied to all charset variables. In the same methos was implemented the logic described in #1785 : `mysql-default_charset` and `mysql-default_collation_connection` must be compatible: * if only one is present, the other is configured automatically * if not compatible, `mysql-default_charset` is configured from `mysql-default_collation_connection`
|
retest this please |
1 similar comment
|
retest this please |
|
retest this please |
…hanged. If mysql-default_charset is changed but mysql-default_collation_connection it is not, use mysql-default_charset to tune mysql-default_collation_connection.
|
retest this please |
|
retest this please |
|
retest this please |
|
retest this please |
|
retest this please |
This was referenced Jun 15, 2020
|
retest this please |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.