Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Closes #3088: Added new json 'attributes' column to 'mysql_query_rules' table #3100

Merged
merged 4 commits into from
Oct 23, 2020
Merged

Closes #3088: Added new json 'attributes' column to 'mysql_query_rules' table #3100

merged 4 commits into from
Oct 23, 2020

Conversation

JavierJF
Copy link
Collaborator

@JavierJF JavierJF commented Oct 8, 2020

Closes #3088.

@renecannao
Copy link
Contributor

I think we need to ensure that ProxySQL_Config::addField() is escaping strings with have double quotes (that can happens with JSON attributes and comments .
This issue is not specific to this commit, but we should ensure this before merging this PR

@renecannao renecannao merged commit b822038 into v2.1.0 Oct 23, 2020
@renecannao renecannao deleted the v2.1.0-3088 branch October 30, 2020 16:09
@JavierJF JavierJF mentioned this pull request Mar 24, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@JavierJF @renecannao