V2.1.0 ps buffer #3295
Merged
V2.1.0 ps buffer #3295
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 07e2b94.
So far this seems to work, although it is dropping most of the rows. The rows are lost intentionally up to this commit.
This new function is meant to split MySQL_ResultSet::init() to later remove all code specific to prepared statements because it assumes it is pre-buffered
* MySQL_ResultSet() stores a pointer to the PS * MySQL_ResultSet::init_with_stmt() doesn't need anymore the pointer to the PS Furthermore, it isn't anymore an "init" but an end (we will rename it) * Added MySQL_ResultSet::add_row(MYSQL_ROWS *rows) for PS only * MySQL_Protocol::generate_pkt_row3() accepts an optional row length. If passed, it will know the length of the row without computing it * MyRS initialized during ASYNC_STMT_EXECUTE_STORE_RESULT_START * Implemented throttling during ASYNC_STMT_EXECUTE_STORE_RESULT_START * MySQL_Connection::process_rows_in_ASYNC_STMT_EXECUTE_STORE_RESULT_CONT() always generates a heartbeat. For now unnecessary, and we will better tune it later * test_ps_async-t.cpp tunes mysql-threshold_resultset_size to trigger buffering More testing is required
|
test this please |
|
retest this please |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.