Closes #3334: Fix crash and memory errors reported by valgrind for v2.1.1 #3335
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…last row from MySQL_STMT::result
…erly updating 'length' from copied last row after data copy
1. Isolated POC for ps_buffer into function. 2. Improved documentation of functions old and introduced checks. 3. Added new query used to trigger a memory error during testing.
renecannao
requested changes
Mar 4, 2021
test/tap/tests/test_ps_async-t.cpp
Outdated
| @@ -220,7 +384,7 @@ int main(int argc, char** argv) { | |||
| // configure the connection as not blocking | |||
| diag("Setting mysql connection non blocking"); | |||
| mysql_options(mysql, MYSQL_OPT_NONBLOCK, 0); | |||
| if (!mysql_real_connect(mysql, cl.host, cl.username, cl.password, NULL, cl.port, NULL, 0)) { | |||
| if (!mysql_real_connect(mysql, cl.host, cl.username, cl.password, NULL, 6033, NULL, 0)) { | |||
There was a problem hiding this comment.
This change should be reverted I believe
There was a problem hiding this comment.
Whoops, yes, thanks you.
test/tap/tests/test_ps_async-t.cpp
Outdated
| if (mysql_stmt_close(stmt2a)) { | ||
| fprintf(stderr, " failed while closing the statement\n"); | ||
| ok(false, " %s\n", mysql_error(mysql)); | ||
| restore_admin(mysql); |
There was a problem hiding this comment.
Thanks, copy paste mistake I'm afraid.
test/tap/tests/test_ps_async-t.cpp
Outdated
| fprintf(stderr, " failed while closing the statement\n"); | ||
| ok(false, " %s\n", mysql_error(mysql)); | ||
| return restore_admin(mysqladmin); | ||
| } | ||
| restore_admin(mysql); |
There was a problem hiding this comment.
Thanks, same as previous one.
…ction handler on 'restore_admin'
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #3334.