Fix floating point exception. #3426
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Automated message: PR pending admin approval for build testing |
|
Merged, thanks for the PR! |
|
Will this be backported to 2.1.x or should I open a PR against that branch? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While working with a large number of backends and replication groups with the default
monitor_read_only_interval, I was repeatedly hitting floating point exceptions in largely unrepeatable ways. A core dump showed that https://github.com/sysown/proxysql/blob/v2.1.1/lib/MySQL_Monitor.cpp#L2800 was where the exception happened. This proposed fix is perhaps not the most appropriate, an error message might need to be generated or other action needs to happen. In the meantime, increasingmonitor_read_only_intervalto a reasonable number has corrected my issue.