Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix malformed packet when connected with MariaDB server with fast_forward flag ON #3996

Merged
merged 3 commits into from
Nov 28, 2022
Merged

Fix malformed packet when connected with MariaDB server with fast_forward flag ON #3996

merged 3 commits into from
Nov 28, 2022

Conversation

rahim-kanji
Copy link
Collaborator

Resolves Issue 3992

  • Removed MARIADB_CLIENT_EXTENDED_METADATA flag

@rahim-kanji
Resolves Issue 3992
f709683 
* Removed MARIADB_CLIENT_EXTENDED_METADATA flag
@pondix
Copy link
Contributor

pondix commented Oct 14, 2022

Automated message: PR pending admin approval for build testing

@renecannao
Copy link
Contributor

add to whitelist

@rahim-kanji rahim-kanji changed the title Resolves Issue 3992 Removed MARIADB_CLIENT_EXTENDED_METADATA flag to fix malformed packet when connected with MariaDB server with fast_forward flag ON Oct 17, 2022
@rahim-kanji rahim-kanji changed the title Removed MARIADB_CLIENT_EXTENDED_METADATA flag to fix malformed packet when connected with MariaDB server with fast_forward flag ON Fix malformed packet when connected with MariaDB server with fast_forward flag ON Oct 17, 2022
@mirostauder
Copy link
Collaborator

retest this please

7 similar comments
@mirostauder
Copy link
Collaborator

retest this please

@mirostauder
Copy link
Collaborator

retest this please

@mirostauder
Copy link
Collaborator

retest this please

@mirostauder
Copy link
Collaborator

retest this please

@mirostauder
Copy link
Collaborator

retest this please

@mirostauder
Copy link
Collaborator

retest this please

@mirostauder
Copy link
Collaborator

retest this please

@rahim-kanji
Resolves Issue 3992
2e6582e 
* Fixed connection lost error when fast forward flag is off.
* Added tap test for regression testing.
@mirostauder
Copy link
Collaborator

retest this please

@rahim-kanji
Resolves Issue 3992
ec5aef6 
* Fixed connection lost error when fast forward flag is off.
* Added tap test for regression testing.
@mirostauder
Copy link
Collaborator

retest this please

2 similar comments
@mirostauder
Copy link
Collaborator

retest this please

@mirostauder
Copy link
Collaborator

retest this please

@renecannao renecannao merged commit 1c896ae into sysown:v2.x Nov 28, 2022
javsanpar added a commit that referenced this pull request Dec 19, 2022
@javsanpar
Add PyMySQL test for malformed packet when using MariaDB with fast_fo…
d53f596 
…rward

Related to issues #3992 and #4047, and to pull request #3996
javsanpar added a commit that referenced this pull request Dec 19, 2022
@javsanpar
Add PyMySQL test for malformed packet when using MariaDB with fast_fo…
97d9e5b 
…rward

Related to issues #3992 and #4047, and to pull request #3996
@javsanpar javsanpar mentioned this pull request Dec 19, 2022
Merged
@javsanpar javsanpar mentioned this pull request Jan 13, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

fast_forward not working in 2.4.4
4 participants
@rahim-kanji @pondix @renecannao @mirostauder