V2.x deprecate eof fixes and tests #4041
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Automated message: PR pending admin approval for build testing |
This was referenced Dec 7, 2022
Fix invalid resultset when using query cache and mixing clients using and not using CLIENT_DEPRECATE_EOF. If a client connects to ProxySQL not using CLIENT_DEPRECATE_EOF and it caches a resultset, when a client using CLIENT_DEPRECATE_EOF executes the same query it will get an invalid resultset and the client will disconnect. The data in the resultset is correct, but proxysql skips a sequence id thus the client assumes it is corrupted.
If a client connects to ProxySQL not using CLIENT_DEPRECATE_EOF and it caches a resultset, when a client using CLIENT_DEPRECATE_EOF executes the same query it will get a resultset with wrong warnings and status flags. This is because warnings and status flags position must be swapped when converting an EOF packet to an OK packet. More info about warnings and status flags position in EOF and OK packets: https://dev.mysql.com/doc/dev/mysql-server/latest/page_protocol_basic_eof_packet.html https://dev.mysql.com/doc/dev/mysql-server/latest/page_protocol_basic_ok_packet.html
Fix unaligned memory access in ok_to_eof_packet() when copying warnings and status flags from OK to EOF packages.
Use the vector which contains inserted data to validate received data from ProxySQL.
Tests if warnings and status flags from OK packets converted to EOF packets, and the other way around, are the same.
libmariadbclient do not cares about sequence id sanity, so it can not be used to test it.
javsanpar
force-pushed
the
v2.x-deprecate_eof_fixes_and_tests
branch
from
57a8150
to
081ef66
Compare
|
Retest this please |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds fixes and tests related to 'CLIENT_DEPRECATE_EOF':