Fix autocommit invalidly reported in several cases #4052
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
javsanpar
force-pushed
the
v2.x-fix_autocommit_handshake_resp
branch
2 times, most recently
from
4797e9c
to
ee20a3e
Compare
Otherwise, autocommit status flag is always zero, instead of displaying its true value. OK responses were reporting an invalid autocommit during handshake, reset_connection and change_user petitions.
Commit c319438484d918cc90d3cd3eb8dd3d4d0eecd5a1 fixed the bug that caused autocommit to be shown as disabled when it is truly enabled.
javsanpar
force-pushed
the
v2.x-fix_autocommit_handshake_resp
branch
from
ee20a3e
to
42600f4
Compare
javsanpar
changed the title
…e_user Adds a test to check that ProxySQL OK responses to reset_connection and change_user petitions have autocommit flag set.
javsanpar
force-pushed
the
v2.x-fix_autocommit_handshake_resp
branch
from
42600f4
to
0e7afa3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also, add tests to check those cases