Refactor and optimize read-only actions + Simulator (combined) #4127
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rahim-kanji
changed the title
rahim-kanji
force-pushed
the
v2.x_refactor_read_only_action_with_simulator
branch
from
b803c8d
to
3aa4055
Compare
|
Hi @rahim-kanji, maybe I'm out of the loop here, any reason for commit 3aa4055 ? Otherwise it should be reverted before merging this PR. It's a fix for fixing incompatibilities between another monitoring threads that call |
Had a discussion and commit reverted. |
|
retest this please |
…ith_simulator' into v2.x_refactor_read_only_action_with_simulator
|
retest this please |
|
Looking great! 🎉 |
…milliseconds, which is then converted into microseconds. Fixed in read_only_actions_v2.
|
retest this please |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactor and optimize read-only actions PR
Optimize read-only actions by removing the dependency on proxysql admin tables. Instead, a separate mapping container is maintained, which records the state of the HGM servers. This avoids the need to call the commit method on every change, which improves performance. The changes in this commit also ensure that the mapping container is properly updated when servers are added, removed or modified.
Read only simulator PR
This commit introduces a first simulator for read_only monitoring
ProxySQL itself will simulate hundreds of backends across hundreds of
hostgroups, all configured in hundreds of clusters, and return read_only
values for each of the simulated backend.
The read_only value can be configured in table READONLY_STATUS available in
the SQLite3Server module.
If a backend isn't configured in table READONLY_STATUS , its default read_only
value is 1.
It is possible to simulate a lot of simultaneous failover running queries like
the following:
UPDATE READONLY_STATUS SET read_only=1;
CREATE TABLE t1 AS SELECT hostname FROM READONLY_STATUS ORDER BY RANDOM() LIMIT 50;
UPDATE READONLY_STATUS SET read_only=0 WHERE hostname IN (SELECT hostname FROM t1);
DROP TABLE t1;