Alternative to Fix invalid memory accesses to 'GloVars::checksums_values' during shutdown #4189
Conversation
…ues' during shutdown This is an alternative implementation of commit cfb34ef because it was failing to compile on clang 14 , that was complaining about a missing unnamed destructor
|
@JavierJF : your feedback is needed |
|
retest this please |
1 similar comment
|
retest this please |
There was a problem hiding this comment.
This solution should work. But since the original type ProxySQL_Checksum_Value is only through its derived class ProxySQL_Checksum_Value_2 in the contexts in which resource deallocation is needed. I think we could get the shutdown logic out of the picture, and make a pure inheritance based solution. Just removing the destructor from ProxySQL_Checksum_Value and leaving that responsibility to the derived classes (right now only ProxySQL_Checksum_Value_2). Patch could be something minimal like the following:
inheritance_solution.patch.tar.gz
Note: It will be required to remove the call to ProxySQL_Checksum_Value ctor from ProxySQL_Checksum_Value2 ctor, since its creating an empty object that is currently never used, but once the destructor is removed, this empty object will leak resources.
…xySQL_Checksum_Value_2 constructor
This is an alternative implementation of commit cfb34ef because it was failing to compile on clang 14 , that was complaining about a missing unnamed destructor