Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reworking of SET parser #4274

Merged
merged 16 commits into from
Jun 30, 2023
Merged

Reworking of SET parser #4274

merged 16 commits into from
Jun 30, 2023

Commits on Jun 26, 2023

  1. Configuration menu
    Copy the full SHA
    4b49c38 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    1450a7f View commit details
    Browse the repository at this point in the history

Commits on Jun 27, 2023

  1. Configuration menu
    Copy the full SHA
    131d2e8 View commit details
    Browse the repository at this point in the history
  2. Adding setparser_test_common.h

    setparser_test_common.h includes the tests for both
    setparser_test2.cpp and setparser_test3.cpp
    renecannao committed Jun 27, 2023
    Configuration menu
    Copy the full SHA
    745204b View commit details
    Browse the repository at this point in the history
  3. Adding 2 more tests

    renecannao committed Jun 27, 2023
    Configuration menu
    Copy the full SHA
    150bdee View commit details
    Browse the repository at this point in the history
  4. Minor tuning on Makefile

    renecannao committed Jun 27, 2023
    Configuration menu
    Copy the full SHA
    b167adc View commit details
    Browse the repository at this point in the history
  5. Minor changes in TAP Makefile

    Disabling jemalloc from TAP tests it saves around 5MB per binary
    
    Also renamed proxysql_find_charset_collate() in proxysqlTap_find_charset_collate()
    renecannao committed Jun 27, 2023
    Configuration menu
    Copy the full SHA
    337f04e View commit details
    Browse the repository at this point in the history

Commits on Jun 28, 2023

  1. Configuration menu
    Copy the full SHA
    62a2ecd View commit details
    Browse the repository at this point in the history
  2. Make SetParser reusable

    Added set_query() to change the query.
    parse1v2() is now able to only once:
    - generate the pattern
    - compile the regex
    renecannao committed Jun 28, 2023
    Configuration menu
    Copy the full SHA
    dcd4a4f View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    536bd62 View commit details
    Browse the repository at this point in the history
  4. Error handling for incomplete parsing in SetParser

    If parse1() or parse1v2() is not able to parse the whole query,
    it doesn't return any result (thus causes an error)
    renecannao committed Jun 28, 2023
    Configuration menu
    Copy the full SHA
    38724bb View commit details
    Browse the repository at this point in the history
  5. Adding variable mysql-set_parser_algorithm

    Variable mysql-set_parser_algorithm defines which algorithm is used by SetParser
    for the parsing of SET statements.
    If value is 1: parse1() is used
    If value is 2: parse1v2() is used
    
    parse1v2() allows also the using a single SetParser per MySQL_Thread to
    process all SET statements. Regex is compiled only once.
    
    set_testing-240-t was also modified to test both algorithms
    renecannao committed Jun 28, 2023
    Configuration menu
    Copy the full SHA
    37f8a50 View commit details
    Browse the repository at this point in the history
  6. Adding test for issue #4268

    renecannao committed Jun 28, 2023
    Configuration menu
    Copy the full SHA
    970922b View commit details
    Browse the repository at this point in the history

Commits on Jun 30, 2023

  1. Configuration menu
    Copy the full SHA
    603b071 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    bb411e2 View commit details
    Browse the repository at this point in the history
  3. Initialize thr_SetParser

    renecannao committed Jun 30, 2023
    Configuration menu
    Copy the full SHA
    a6ff9e3 View commit details
    Browse the repository at this point in the history