Fix infinite loop for SSL connections - Closes #4314 #4321
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If a peer closes the socket under certain timing conditions, e.g. during connection establishment, an infinite loop will take place if 'POLLHUP' and 'POLLIN' are set in the socket, and no data is present, just the final 'EOF'.
- Fix regression test 'reg_test_3273_ssl_con-t' with more restrictive traffic control rules so they don't affect the whole interface. - Fix measurement of CPU usage in two regression tests.
5 tasks
- Removed redundant part of check. - Updated comment, elaborating on 'POLLHUP' omission in the check.
This was referenced Aug 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If a peer closes the socket under certain timing conditions, e.g. during connection establishment, an infinite loop will take place if
POLLHUPandPOLLINare set in the socket, and no data is present, just the finalEOF.Fix details:
This was due to
read_data_from_netonly expectingPOLLINflag to be set inrevents. The scenario werePOLLHUPandPOLLINare both present is now covered by this PR.