Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dynamically linking on TAP tests #4330

Merged
merged 35 commits into from
Aug 31, 2023
Merged

Dynamically linking on TAP tests #4330

merged 35 commits into from
Aug 31, 2023

Conversation

renecannao
Copy link
Contributor

@renecannao renecannao commented Aug 18, 2023 •
edited
Loading

Modified the compiling of TAP tests to not use statically linking for:

  • SSL (libssl and libcrypto)
  • TAP (libtap and libcpp_dotenv)

Because very few TAP tests still need static linking , cpp_dotenv is compiled both as shared and static library , and same for libtap .
Before executing TAP tests, these environment variables need to be set:

This PR also disables the use of the statically linked curl and will rely on the installed one.

export LD_LIBRARY_PATH="$PROXYSQL_PATH/test/tap/tap"

Before merging this PR, the tester needs to be modified accordingly.

@renecannao
Copy link
Contributor Author

retest this please

@renecannao
Copy link
Contributor Author

retest this please

@renecannao renecannao changed the title Dynamically linking on TAP tests [DO NOT MERGE yet] Dynamically linking on TAP tests Aug 22, 2023
@renecannao renecannao marked this pull request as draft August 22, 2023 13:02
@mirostauder
Copy link
Collaborator

retest this please

6 similar comments
@mirostauder
Copy link
Collaborator

retest this please

@mirostauder
Copy link
Collaborator

retest this please

@mirostauder
Copy link
Collaborator

retest this please

@mirostauder
Copy link
Collaborator

retest this please

@mirostauder
Copy link
Collaborator

retest this please

@mirostauder
Copy link
Collaborator

retest this please

@renecannao renecannao marked this pull request as ready for review August 30, 2023 19:36
@renecannao renecannao merged commit 7d81a23 into v2.x Aug 31, 2023
163 checks passed
@renecannao renecannao deleted the v2.x-tap_dyn branch August 29, 2024 11:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@renecannao @mirostauder