-
Notifications
You must be signed in to change notification settings - Fork 976
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix clang compilation for tests dep 'cppdotenv' #4468
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added fixes based on CLang warnings:
other:
ASAN breaks with ASLR > 28bits used by recent kernels |
retest this please |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Minimal changes for fixing the
cppdotenv
compilation underclang
. Removes an unnecessaryusing
directive since fully qualified names are used within the file anyway.Extra details
There is another potential solution, that involves fixing all the ambiguities that arise when the namespace is included in the global one by the
using
directive. Several changes are required within the same file, for fixing these ambiguities,clang
appears more sensitive thatgcc
and requires a full path from global namespace::
for being able to do proper name resolution. It's left here as no more than an interesting read:nm_clang_fix_fqualified.txt