Correct free/used typo in Prometheus 'connection_pool' gauge cleanup #4470
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
saunderst
force-pushed
the
connection_pool-gauge-typo
branch
from
47fa83d
to
041c3d7
Compare
|
Hi @saunderst . Thank you for the fix! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In
MySQL_HostGroups_Manager::p_update_connection_pool(), in the section that cleans up connection pool gauge metrics associated with missing servers, this is correcting a typo switching "free" and "used" such that the "Remove" method is being called on the wrong gauge.