Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PENDING] Add new table ssl_ciphers to ProxySQL Admin #4519

Draft
wants to merge 3 commits into
base: v2.x
Choose a base branch
from

Conversation

JavierJF
Copy link
Collaborator

This PR adds a new table ssl_ciphers to ProxySQL Admin. This table allows to check the currently supported ciphers by ProxySQL. The table is populated during startup and it's never save to disk, in a similar fashion to mysql_collations table.

It's defined with two rows cipher_name and cipher_description. A simple output for completion:

mysql> SELECT * FROM ssl_ciphers LIMIT 2;
+------------------------------+-------------------------------------------------------------------------------------------------+
| cipher_name                  | cipher_description                                                                              |
+------------------------------+-------------------------------------------------------------------------------------------------+
| TLS_AES_256_GCM_SHA384       | TLS_AES_256_GCM_SHA384         TLSv1.3 Kx=any      Au=any   Enc=AESGCM(256)            Mac=AEAD |
| TLS_CHACHA20_POLY1305_SHA256 | TLS_CHACHA20_POLY1305_SHA256   TLSv1.3 Kx=any      Au=any   Enc=CHACHA20/POLY1305(256) Mac=AEAD |
+------------------------------+-------------------------------------------------------------------------------------------------+
2 rows in set (0.00 sec)

@renecannao renecannao changed the title Add new table 'ssl_ciphers' to ProxySQL Admin [PENDING] Add new table 'ssl_ciphers' to ProxySQL Admin Apr 24, 2024
@renecannao renecannao marked this pull request as draft April 24, 2024 03:42
@renecannao
Copy link
Contributor

Table definitions like ADMIN_SQLITE_TABLE_SSL_CIPHERS is being moved away from ProxySQL_Admin.cpp . Putting this PR on hold until that migration is completed.

Added primary key
Added space for better formatting
@renecannao renecannao changed the title [PENDING] Add new table 'ssl_ciphers' to ProxySQL Admin [PENDING] Add new table ssl_ciphers to ProxySQL Admin Apr 24, 2024
@mirostauder
Copy link
Collaborator

Can one of the admins verify this patch?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants